Fix lazyloading - #148
Open
eliandoran wants to merge 2 commits into
Open
Conversation
DanielKulbe
suggested changes
Mar 18, 2026
| katexRenderOptions: KatexOptions = {} | ||
| ): Promise<void> { | ||
| if ( engine == 'mathjax' ) { | ||
| if ( engine == 'mathjax' && window.MathJax !== undefined ) { |
Contributor
There was a problem hiding this comment.
Should be global.window.MathJax
| } | ||
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition | ||
| } else if ( engine === 'katex' ) { | ||
| } else if ( engine === 'katex' && window.katex !== undefined ) { |
Contributor
There was a problem hiding this comment.
Should be global.window.katex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that the conversion to TypeScript broke the lazyloading (first introduced in #5), we noticed it in production after upgrading to 41.4.2.
Identified an older version where it used to work: 9fa8967
Since
engineis set tokatex, butkatexisundefinedit proceeds to render and it crashes:Since the old code checked for the presence of the
katexinstance, it would avoid this branch and continue to the lazy loading one.Also took a time to write a test, but it is not perfect. It successfully caught the original issue and it passes now that the issue is fixed. I can't seem to be able to write a test for
lazyloadsince it always seems that the second test fails (some kind of leak, maybe?).