Migrate to Typescript - #127
Closed
fedemp wants to merge 21 commits into
Closed
Conversation
fedemp
marked this pull request as draft
February 27, 2024 00:17
Closed
fedemp
marked this pull request as ready for review
February 27, 2024 23:47
Collaborator
|
@fedemp FYI: I am going to release 41.2.0 - you may need to rebase soon. Sorry I have not gotten to this yet! |
Closed
Contributor
Author
|
No problem! 👍 |
Collaborator
|
@fedemp Hm, I have opened this yet (will on the weekend) - but this would have merge conflicts.
Do you know how to rebase? Can you take a look? |
Contributor
Author
|
I've created a new PR. It seems that so many commits makes it impossible to rebase. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These PR migrate the source to TS. Tests are not included cause some issues with Webpack.