Monitor MachinePool Health based on standalone kustomizations#1476
Open
friegger wants to merge 1 commit into
Open
Monitor MachinePool Health based on standalone kustomizations#1476friegger wants to merge 1 commit into
friegger wants to merge 1 commit into
Conversation
This change mostly consists of three parts: 1. A MachinePool lifecycle controller: Implements `machinepool-lifecycle-controller` monitoring MachinePool health, with corresponding API additions for MachinePool/VolumePool/BucketPool conditions, codegen updates 2. A pool health heartbeat runnable in the machinepoollet: The poollet now actively reports pool liveness so the lifecycle controller can set pools whose poollets have gone away to Unknown. It also includes kustomizations adding the Lease namespace and RBAC adjustments. The MachinePoolHeartbeat, a ticker-driven Runnable that probes the IRI runtime via Status, renews the pool's Lease in ironcore-machinepool-lease, and patches Ready only when its value or observedGeneration actually changes. Errors on either sub-step are logged and retried on the next tick; the lifecycle controller's grace period absorbs short blips. Lease takeover from a previous holder is logged at Info. Contains app arguments that make the heartbeat intervals configurable, defaulting to the IEP-15 values. 3. Lease namespaces and RBACs Contributes to #1472 Signed-off-by: Felix Riegger <felix.riegger@sap.com>
friegger
force-pushed
the
enh/1472-pool-health-on-standalone-ks
branch
from
75d6863 to
20479ee
Compare
friegger
changed the title
adracus
requested changes
May 26, 2026
Contributor
adracus
left a comment
adracus
left a comment
There was a problem hiding this comment.
What about the remaining pool health controllers / reconcilers? If we want to make this change only about machine pools, we should either remove everything else or add the rest.
Contributor
There was a problem hiding this comment.
Please use Ginkgo + Gomega for our tests. In this case, table based tests might also make sense.
| } | ||
|
|
||
| type MachinePoolHealth struct { | ||
| lastObservedTime time.Time |
Contributor
There was a problem hiding this comment.
Why do we record the lastObservedTime? We do not make any checks based on this.
|
|
||
| machinePool := &computev1alpha1.MachinePool{} | ||
| if err := r.Get(ctx, req.NamespacedName, machinePool); err != nil { | ||
| return ctrl.Result{}, client.IgnoreNotFound(err) |
Contributor
There was a problem hiding this comment.
In case the machine pool is not found, we should free the health data, otherwise the data might pile up.
| return nil | ||
| } | ||
|
|
||
| func (h *MachinePoolHeartbeat) reconcileReadyCondition(ctx context.Context, statusErr error) error { |
Contributor
There was a problem hiding this comment.
The ready condition is reconciled by the MachinePoolReconciler - we should amend setting the condition there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
machinepool-lifecycle-controllermonitoring MachinePool health, with corresponding API additions for MachinePool/VolumePool/BucketPool conditions, codegen updatesThe poollet now actively reports pool liveness so the lifecycle controller can set pools whose poollets have gone away to Unknown. It also includes kustomizations adding the Lease namespace and RBAC adjustments. The MachinePoolHeartbeat, a ticker-driven Runnable that probes the IRI runtime via Status, renews the pool's Lease in ironcore-machinepool-lease, and patches Ready only when its value or observedGeneration actually changes. Errors on either sub-step are logged and retried on the next tick; the lifecycle controller's grace period absorbs short blips. Lease takeover from a previous holder is logged at Info. Contains app arguments that make the heartbeat intervals configurable, defaulting to the IEP-15 values.
Contributes to #1472