feat(web): deploy web version for normal users on GitHub pages#728
Open
WofWca wants to merge 5 commits intoioquake:mainfrom
Open
feat(web): deploy web version for normal users on GitHub pages#728WofWca wants to merge 5 commits intoioquake:mainfrom
WofWca wants to merge 5 commits intoioquake:mainfrom
Conversation
This allows us to deploy a public static page that does not require manually adding the `.pk3` files to the HTTP server's directory. This way the page can be used by regular people. Additionally, in the future this might simplify the development workflow of reviewing MRs, because this does not require downloading any files to run the preview build. The approach is taken from - https://github.com/jdarpinian/ioq3/blob/7801abd5ac510a889087ad62473c54dbe509e106/code/web/index.html#L614-L660 - https://github.com/WofWca/quake3.xdc/blob/be18795b56a0e408514e78201a731f38c1a92bc6/upload-full-version.html Co-authored-by: James Darpinian <jdarpinian@gmail.com>
This simplifies navigating to the web version. You don't have to search and click the `ioquake3.html` file. This is especially useful for the GitHub pages deployment. The deployment workflows sort of expect `index.html` to be present. They usually print `.../ioq3/` as the final URL, but GitHub pages doesn't allow you to browse the files. It simply says `404` if there is no `index.html`. This commit should fix it.
Member
|
Many people consider GitHub to have significant issues that have never been addressed and I do not want to encourage the usage of more GitHub features that make it more difficult to leave this place. |
Author
|
OK, if I remove the workflow file and add some instructions instead, would it be acceptable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deploys the web version to GitHub pages
The website does not require manually adding the
.pk3filesto the HTTP server's directory.
This way the page can be used by regular people.
I have tested the deployment on my fork. You can try it here:
https://wofwca.github.io/ioq3.
2025-06-19-zy5XciYPZJ.mp4
The new page,
upload-game-files-to-cache.htmlin its current state only supportsbaseq3, but can be adjusted later to support Team Arena and the demo version of Quake III Arena or Team Arena. Maybe even with mods.Additionally, in the future this might simplify
the development workflow of reviewing MRs,
because this does not require downloading any files
to run the preview build.
The approach is taken from
The commits are self-contained and can be merged on-by-one (in sequence). I suggest a non-squash merge.