PDF generation: use playwright instead of pyppeteer - #59
Open
underscore-j wants to merge 1 commit into
Open
Conversation
Member
|
It's a good idea, I will give it some testing after the IOI is over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyppeteer, by default, uses a pretty outdated version of chromium (117.0.5938.0).That version does not handle tables over page breaks very well, in some cases causing tables that don't fit at the bottom of a page to be spread across multiple pages, with those pages being otherwise empty.
The resulting statements could be extremely confusing to contestants.
By swapping out
pyppeteerforplaywright, we can use a more recent version of chromium, which handles tables much better (in the aforementioned case, the entire table will be placed after the page break, intact).