Reroute nothing stdlib mod to the root logger#185
Merged
Conversation
Closes #181 NOTE: This seems more internally consistent than having a separate logger for this case?
Since we're just avoiding an error bumping the patch release is probably safe.
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
==========================================
- Coverage 98.30% 98.26% -0.04%
==========================================
Files 14 14
Lines 413 404 -9
==========================================
- Hits 406 397 -9
Misses 7 7
Continue to review full report at Codecov.
|
Contributor
|
Thanks! Looks good to me. Can't approve as I don't have write access. |
Member
|
Should add a test |
mjram0s
approved these changes
Apr 29, 2022
Member
Author
|
TODO: We should probably backport this fix since CloudWatchLogs has upperbounded things to 1.2. |
Contributor
Ah yes, that's probably the easiest to deal with our issues. Will do that. EDIT here: #190 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #181
NOTE: This seems more internally consistent than having a separate logger for this case?