Skip to content

fix: handle 404 status when deleting release branch in protected-branch plugin #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gh-brice-messeca wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

fix: handle 404 status when deleting release branch in protected-branch plugin #2523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugins/protected-branch/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@ export default class ProtectedBranchPlugin implements IPlugin {
});
} catch (e) {
// Silently ignore reference not found error since the ref might already be deleted
if (!e || e.status !== 422 || e.message !== "Reference does not exist") {
// GitHub API may return either 422 or 404 for non-existent references
if (!e || (e.status !== 422 && e.status !== 404) || e.message !== "Reference does not exist") {
throw e;
}
}
Expand Down