Repository navigation
gemm: pass this by reference for kernel lambda captures - #841
Merged
Merged
Conversation
|
Note: We don't currently validate with C++20 so there might be other issues. |
rolandschulz
approved these changes
Jul 28, 2026
taozha2
approved these changes
Sep 22, 2026
C++20 has deprecated implicit capture by value for `this` with `[=](){`.
An alternative fix is to explicitly include `this` in the capture list
with `[=, this](){`. However, this emits a warning on C++17 and below.
taozha2
enabled auto-merge (squash)
September 22, 2026 06:22
tdeng5
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
C++20 has deprecated implicit capture by value for
thiswith[=](){. An alternative fix is to explicitly includethisin the capture list with[=, this](){. However, this emits a warning with C++17 and below.These warnings currently cause
vllm-xpu-kernelsto fail building withtorch>=2.13,C++20support mandated for kernels, and-Werrorenabled.Type
Testing
References
This issue is inherited from upstream. There is an outstanding PR on CUTLASS's repository that also fixes this issue (see NVIDIA#2997), however it is stale.
Checklist