Skip to content
This repository was archived by the owner on Mar 10, 2026. It is now read-only.

feat(YouTube): Update Overlay buttons, add Hide live chat messages and more Start page options#50

Merged
inotia00 merged 15 commits intoinotia00:devfrom
anddea:filter
May 21, 2024
Merged

feat(YouTube): Update Overlay buttons, add Hide live chat messages and more Start page options#50
inotia00 merged 15 commits intoinotia00:devfrom
anddea:filter

Conversation

@anddea
Copy link
Copy Markdown

@anddea anddea commented May 16, 2024

inotia00/revanced-integrations#39

Each commit has its own conventional message that describes features and fixes.

@inotia00
Copy link
Copy Markdown
Owner

Whitelist setting is not implemented.
@anddea, Please remove icons and patches related with the whitelist.

@Francesco146
Copy link
Copy Markdown

Whitelist setting is not implemented. @anddea, Please remove icons and patches related with the whitelist.

are you planning to implement it in the future? YT-Advanced is near a full implementations after the big refactor

@inotia00
Copy link
Copy Markdown
Owner

are you planning to implement it in the future? YT-Advanced is near a full implementations after the big refactor

The channel whitelist is a feature that existed in YouTube Vanced that I ported to revanced-patches around December 2022.

Release notes
https://github.com/inotia00/revanced-patches/releases/tag/v2.147.0
Source: TeamVanced/Integrations
TeamVanced/Integrations#74

Since YouTube API v1 was deprecated, I removed the channel whitelist around August 2023.

Release notes
https://github.com/inotia00/revanced-patches/releases/tag/v2.168.30

@YT-Advanced restored the code I removed, but it is not compatible with revanced-patches-4.x.x.
(Some code is still based on Vanced integration and requires refactoring.)

@Francesco146
Copy link
Copy Markdown

understood, thanks for the infos

@anddea
Copy link
Copy Markdown
Author

anddea commented May 19, 2024

I'll remove later, in 48 hours. There should be only whitelist icons, no code related to it.

@inotia00
Copy link
Copy Markdown
Owner

@anddea Please review comments

@anddea
Copy link
Copy Markdown
Author

anddea commented May 21, 2024

What comments are you referring to? This PR comments, the PR where you mentioned this PR, code comments?

Copy link
Copy Markdown
Owner

@inotia00 inotia00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it's my fault, I forgot to submit comments

Comment thread src/main/resources/youtube/settings/host/values/strings.xml Outdated
@inotia00
Copy link
Copy Markdown
Owner

I tested it a while ago and all settings seem to work as intended

Can I merge PR?

@inotia00
Copy link
Copy Markdown
Owner

Thanks

@inotia00 inotia00 merged commit 84dd65f into inotia00:dev May 21, 2024
@anddea anddea deleted the filter branch June 26, 2024 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants