fix(scripts): fix progress calculation message, handle fully synced state, and strip binary checksum prefix - #89
Open
yappermoar-boop wants to merge 1 commit into
Conversation
…tate, and strip binary checksum prefix
kutluhaneth46
approved these changes
Sep 5, 2026
kutluhaneth46
left a comment
kutluhaneth46
left a comment
There was a problem hiding this comment.
Review
Two solid fixes in one PR:
progress.sh: clearer error when local > remote, clean exit on fully synced (BEHIND == 0), and mutually exclusive ETA buckets (same class of bug as #81, with a nicer fully-synced path).scripts/utils.sh: stripping a leading*from the checksum filename handles the GNUsha256sum --binary/*filenameform, which previously failed the format check.
LGTM.
kutluhaneth46
left a comment
kutluhaneth46
left a comment
There was a problem hiding this comment.
Review
Two solid fixes in one PR:
progress.sh: clearer error when local > remote, clean exit on fully synced (BEHIND == 0), and mutually exclusive ETA buckets (same class of bug as #81, with a nicer fully-synced path).scripts/utils.sh: stripping a leading*from the checksum filename handles the GNUsha256sum --binary/*filenameform, which previously failed the format check.
Looks good from a community review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In progress.sh, corrected the inverted error message when BEHIND < 0, added early exit for fully synced nodes (BEHIND == 0), and structured time estimate reporting using if/elif/else to avoid duplicate output. In scripts/utils.sh, stripped optional leading asterisk from binary-mode checksum files in verify_sha256_checksum.