Conversation
|
@copilot thoughts? |
The overall approach looks solid — keeping Subduction-specific logic well-isolated (repo-factory, waitForSync fallback, skipping recreateFailedDocuments) and the comments are thorough. A few observations worth considering: Potential false positive in
|
There was a problem hiding this comment.
Pull request overview
This PR updates pushwork’s Automerge dependencies to the latest Subduction-enabled automerge-repo and introduces/threads a --sub CLI flag to use the Subduction sync backend (including a new head-stability-based sync wait path when no StorageId is available).
Changes:
- Bump Automerge/Repo packages to
2.6.0-subduction.9and add@automerge/automerge-subduction. - Add
--subflag wiring through CLI → commands → repo creation + sync engine, with Subduction defaults and behavior tweaks. - Add unit/integration coverage for Subduction config, repo creation, and the new
waitForSyncmode.
Reviewed changes
Copilot reviewed 13 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils/repo-factory.ts |
Adds ESM dynamic import + Wasm init and conditional Subduction vs WebSocket repo setup |
src/utils/network-sync.ts |
Adds head-stability polling path for waitForSync when StorageId is absent |
src/core/sync-engine.ts |
Threads sub option to adjust sync verification + retry behavior |
src/commands.ts |
Wires sub into repo creation and sync execution; sets default Subduction endpoint |
src/cli.ts |
Adds --sub option to several commands and passes it through |
src/types/config.ts |
Adds DEFAULT_SUBDUCTION_SERVER and sub?: boolean option fields |
test/unit/*sub*.test.ts, test/integration/sub-flag.test.ts |
Adds unit + integration tests covering Subduction mode |
package.json, pnpm-lock.yaml |
Dependency updates for Subduction-enabled Automerge packages |
CLAUDE.md |
Documents Subduction backend behavior and implementation details |
flake.nix, flake.lock, .gitignore |
Adds Nix dev shell support and ignores Nix/pnpm artifacts |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.