fix(android): upgrade build toolchain for Sonar compatibility - #125
Conversation
WalkthroughThe Android module now uses updated Kotlin, Android SDK, Gradle, and Android DSL versions. The manifest declares no package attribute. Unix and Windows Gradle wrappers receive synchronized compatibility and exit-code updates. ChangesAndroid and Gradle modernization
Estimated code review effort: 3 (Moderate) | ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@kotlin/android/gradle.properties`:
- Around line 1-4: Update the Android toolchain version properties represented
by SecureKeystore_kotlinVersion, the Gradle version, and the Android Gradle
Plugin version as a compatible set: retain the required Gradle minimum, use a
Kotlin version supported by that Gradle release, and set AGP to at least 8.1.1
for the existing SDK 34 values.
In `@kotlin/android/gradle/wrapper/gradle-wrapper.properties`:
- Around line 3-5: Add the official SHA-256 checksum for the Gradle 8.5 binary
distribution as the distributionSha256Sum property in the Gradle wrapper
configuration, alongside distributionUrl. Preserve the existing URL, timeout,
and validateDistributionUrl settings.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f8784a89-7c1c-4561-a679-44875c06f07d
⛔ Files ignored due to path filters (1)
kotlin/android/gradle/wrapper/gradle-wrapper.jaris excluded by!**/*.jar
📒 Files selected for processing (6)
kotlin/android/build.gradlekotlin/android/gradle.propertieskotlin/android/gradle/wrapper/gradle-wrapper.propertieskotlin/android/gradlewkotlin/android/gradlew.batkotlin/android/src/main/AndroidManifest.xml
Signed-off-by: abhip2565 <paul.apaul.abhishek.ap@gmail.com>
bb26d0d to
27b6e79
Compare
* Merge pull request #115 from tw-mosip/bump-up-version chore: bump of libray publish version - 1.0.0-alpha.1-SNAPSHOT * refactor: remove js folder (#116) Signed-off-by: KiruthikaJeyashankar <kiruthikavjshankar@gmail.com> * [inji/inji-wallet#2539] Replace MPL License with Apache License 2.0 (#118) Signed-off-by: Mahesh-Binayak <Mahesh-Binayak@users.noreply.github.com> Co-authored-by: Mahesh-Binayak <Mahesh-Binayak@users.noreply.github.com> * refactor: udpate license to Apache 2.0 (#123) Signed-off-by: Kaushik Gupta <146950347+Kaushikgupta469@users.noreply.github.com> * Fixes: mosip#373 - Updated push-trigger.yml, android-artifact-build.yml and tag.yml files. (#124) Signed-off-by: Mohanraj209 <mohan1715@gmail.com> Co-authored-by: Mohanraj209 <mohan1715@gmail.com> * fix(android): upgrade build toolchain for Sonar compatibility (#125) Signed-off-by: abhip2565 <paul.apaul.abhishek.ap@gmail.com> * Fixes: mosip#373 - Updated push-trigger file. (#126) * Fixes: mosip#373 - Updated push-trigger.yml, android-artifact-build.yml and tag.yml files. Signed-off-by: Mohanraj209 <mohan1715@gmail.com> * Fixes: mosip#373 - Updated push-trigger file. Signed-off-by: Mohanraj209 <mohan1715@gmail.com> --------- Signed-off-by: Mohanraj209 <mohan1715@gmail.com> Co-authored-by: Mohanraj209 <mohan1715@gmail.com> * update workflows to use tagged version of kattu and skip sonar job (#127) * Update workflow to use tag version of kattu and commented sonar job Signed-off-by: Kaushik Gupta <146950347+Kaushikgupta469@users.noreply.github.com> * update tag.yml to tag.yaml to point to kattu tag version-0.0.1 Signed-off-by: Kaushik Gupta <146950347+Kaushikgupta469@users.noreply.github.com> --------- Signed-off-by: Kaushik Gupta <146950347+Kaushikgupta469@users.noreply.github.com> * [DSD-10674] inji-wallet 1.0.0-alpha.1 release chanegs (#128) Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com> * fix: add missing signing config to android publish artifact (#129) * fix: add missing signing config to android publish artifact Signed-off-by: abhip2565 <paul.apaul.abhishek.ap@gmail.com> * fix(gpg): apply signing plugin to Kotlin module Signed-off-by: abhip2565 <paul.apaul.abhishek.ap@gmail.com> --------- Signed-off-by: abhip2565 <paul.apaul.abhishek.ap@gmail.com> --------- Signed-off-by: KiruthikaJeyashankar <kiruthikavjshankar@gmail.com> Signed-off-by: Mahesh-Binayak <Mahesh-Binayak@users.noreply.github.com> Signed-off-by: Kaushik Gupta <146950347+Kaushikgupta469@users.noreply.github.com> Signed-off-by: Mohanraj209 <mohan1715@gmail.com> Signed-off-by: abhip2565 <paul.apaul.abhishek.ap@gmail.com> Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com> Co-authored-by: KiruthikaJeyashankar <kiruthikavjshankar@gmail.com> Co-authored-by: Mahesh-Binayak <76687012+Mahesh-Binayak@users.noreply.github.com> Co-authored-by: Mahesh-Binayak <Mahesh-Binayak@users.noreply.github.com> Co-authored-by: Kaushik Gupta <146950347+Kaushikgupta469@users.noreply.github.com> Co-authored-by: Mohan E <mohanraj1715@gmail.com> Co-authored-by: Mohanraj209 <mohan1715@gmail.com> Co-authored-by: abhip2565 <paul.apaul.abhishek.AP@gmail.com> Co-authored-by: Praful Rakhade <prafulrakhade02@gmail.com> Co-authored-by: Swati Goel <swati@inji.io>
Summary
Verification
./gradlew clean buildwith JDK 17