Skip to content

fix(inputs.huebridge): Repair CI after go-hue v1.2.0 upgrade#18778

Merged
srebhan merged 1 commit intoinfluxdata:masterfrom
skartikey:fix/huebridge-ci-after-gohue-v1.2.0
Apr 22, 2026
Merged

fix(inputs.huebridge): Repair CI after go-hue v1.2.0 upgrade#18778
srebhan merged 1 commit intoinfluxdata:masterfrom
skartikey:fix/huebridge-ci-after-gohue-v1.2.0

Conversation

@skartikey
Copy link
Copy Markdown
Contributor

Summary

The go-hue v1.2.0 bump (#18742) left two CI failures on master:

  • go.sum carried stale entries for go-openapi/jsonpointer, mailru/easyjson, and oapi-codegen/runtime. Re-running go mod tidy removes them.

  • TestGatherLocal expected light_level_lux=3.0860289794360645, which is the math.Pow result on darwin/arm64. On linux/amd64 and windows/amd64 (where CI runs) math.Pow(10, 0.4894) returns the adjacent ULP (3.086028979436064), so the test failed. Use cmpopts.EquateApprox to absorb the 1-ULP difference, matching the chrony test pattern.

Checklist

Related issues

resolves #

The go-hue v1.2.0 bump (influxdata#18742) left two CI failures on master:

- go.sum carried stale entries for go-openapi/jsonpointer,
  mailru/easyjson, and oapi-codegen/runtime. Re-running go mod
  tidy removes them.

- TestGatherLocal expected light_level_lux=3.0860289794360645,
  which is the math.Pow result on darwin/arm64. On linux/amd64
  and windows/amd64 (where CI runs) math.Pow(10, 0.4894) returns
  the adjacent ULP (3.086028979436064), so the test failed. Use
  cmpopts.EquateApprox to absorb the 1-ULP difference, matching
  the chrony test pattern.
@telegraf-tiger telegraf-tiger Bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 22, 2026
@telegraf-tiger
Copy link
Copy Markdown
Contributor

@skartikey skartikey added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 22, 2026
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skartikey!

@srebhan srebhan merged commit 36b6ad4 into influxdata:master Apr 22, 2026
27 checks passed
@github-actions github-actions Bot added this to the v1.38.4 milestone Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants