Skip to content

inputs/kapacitor: always tag nested metrics with the source URL #18733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SAY-5 wants to merge 1 commit into from
Closed

inputs/kapacitor: always tag nested metrics with the source URL #18733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions plugins/inputs/kapacitor/kapacitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,20 @@ func (k *Kapacitor) gatherURL(
delete(obj.Tags, key)
}

// Always tag with the source URL so metrics from multiple
// Kapacitor instances are distinguishable downstream. The
// top-level kapacitor / kapacitor_memstats metrics already
// carry it, but kapacitor_edges / kapacitor_ingress /
// kapacitor_load did not, which made it impossible to tell
// which instance a row came from when the plugin polled
// more than one URL (see influxdata/telegraf#18645).
if obj.Tags == nil {
obj.Tags = make(map[string]string, 1)
}
if _, present := obj.Tags["url"]; !present {
obj.Tags["url"] = url
}

// Convert time-related string field to int
if _, ok := obj.Values["avg_exec_time_ns"]; ok {
d, err := time.ParseDuration(obj.Values["avg_exec_time_ns"].(string))
Expand Down
Loading