OpenSource Resume is supported only with Elasticsearch.#14233
OpenSource Resume is supported only with Elasticsearch.#14233asiroliu merged 1 commit intoinfiniflow:mainfrom
Conversation
📝 WalkthroughWalkthroughA configuration validation gate was added to the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@rag/app/resume.py`:
- Around line 2490-2491: The engine-check raising an exception
(settings.DOC_ENGINE.lower() != "elasticsearch") currently occurs before the
try/except and bypasses the parser's graceful failure path; move this check
inside the existing try block used by the parser so that when the engine is
unsupported you call logger.exception (or logger.error with context), invoke the
same failure callback (callback(-1, ...)) and return [] just like other
exceptions are handled; ensure you reference the same symbols used in the file
(settings.DOC_ENGINE, logger, callback) and add a clear log message stating the
unsupported engine to satisfy the "Add logging for new flows" guideline.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14233 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 10 10
Lines 690 690
Branches 108 108
=======================================
Hits 667 667
Misses 8 8
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…4233) ### What problem does this PR solve? OpenSource Resume is supported only with Elasticsearch. ### Type of change - [x] Bug Fix (non-breaking change which fixes an issue)
What problem does this PR solve?
OpenSource Resume is supported only with Elasticsearch.
Now

Type of change