Skip to content

OpenSource Resume is supported only with Elasticsearch.#14233

Merged
asiroliu merged 1 commit intoinfiniflow:mainfrom
wangq8:bugfix/fix-regression
Apr 21, 2026
Merged

OpenSource Resume is supported only with Elasticsearch.#14233
asiroliu merged 1 commit intoinfiniflow:mainfrom
wangq8:bugfix/fix-regression

Conversation

@wangq8
Copy link
Copy Markdown
Collaborator

@wangq8 wangq8 commented Apr 20, 2026

What problem does this PR solve?

OpenSource Resume is supported only with Elasticsearch.

Now
img_v3_0210u_37519504-78a6-48c3-bac9-bbc3cf47ce3g

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 20, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

📝 Walkthrough

Walkthrough

A configuration validation gate was added to the chunk(...) function in rag/app/resume.py that checks whether the document engine is set to Elasticsearch, raising an exception with a specific error message if the condition is not met.

Changes

Cohort / File(s) Summary
Configuration Validation
rag/app/resume.py
Added import of settings module and a precondition check in chunk(...) that raises an exception unless DOC_ENGINE is configured to "elasticsearch" (case-insensitive).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A little check hops into place,
"Elasticsearch, show your face!"
Before we parse resumes with care,
We validate the engine there.
Configuration gates stand tall and proud,
In five small lines, our standards loud! 📄✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR description is incomplete. While it identifies the problem, it lacks detailed explanation of the issue, the solution implemented, and impact assessment. Complete the description by explaining the bug that was occurring, the root cause, how the fix addresses it, and any testing or impact considerations. Add more context to help reviewers understand the full scope.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding a configuration requirement that Resume functionality only works with Elasticsearch.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@wangq8 wangq8 requested review from asiroliu and yuzhichang April 20, 2026 12:15
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@rag/app/resume.py`:
- Around line 2490-2491: The engine-check raising an exception
(settings.DOC_ENGINE.lower() != "elasticsearch") currently occurs before the
try/except and bypasses the parser's graceful failure path; move this check
inside the existing try block used by the parser so that when the engine is
unsupported you call logger.exception (or logger.error with context), invoke the
same failure callback (callback(-1, ...)) and return [] just like other
exceptions are handled; ensure you reference the same symbols used in the file
(settings.DOC_ENGINE, logger, callback) and add a clear log message stating the
unsupported engine to satisfy the "Add logging for new flows" guideline.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e807973a-9ec3-44e8-b235-3e8a38c57a74

📥 Commits

Reviewing files that changed from the base of the PR and between c43367e and 0b1107a.

📒 Files selected for processing (1)
  • rag/app/resume.py

Comment thread rag/app/resume.py
@wangq8 wangq8 marked this pull request as draft April 21, 2026 01:38
@wangq8 wangq8 added the ci Continue Integration label Apr 21, 2026
@wangq8 wangq8 marked this pull request as ready for review April 21, 2026 01:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.66%. Comparing base (c43367e) to head (0b1107a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14233   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files          10       10           
  Lines         690      690           
  Branches      108      108           
=======================================
  Hits          667      667           
  Misses          8        8           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asiroliu asiroliu merged commit 8aab158 into infiniflow:main Apr 21, 2026
2 checks passed
JasleenKaurSethi pushed a commit to stackhpc/ragflow that referenced this pull request Apr 28, 2026
…4233)

### What problem does this PR solve?

OpenSource Resume is supported only with Elasticsearch.

### Type of change

- [x] Bug Fix (non-breaking change which fixes an issue)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continue Integration size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants