Skip to content
Open
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions deepdoc/parser/mineru_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@
return "@@{}\t{:.1f}\t{:.1f}\t{:.1f}\t{:.1f}##".format("-".join([str(p) for p in pn]), x0, x1, top, bott)

def crop(self, text, ZM=1, need_position=False):
imgs = []

Check failure on line 361 in deepdoc/parser/mineru_parser.py

View workflow job for this annotation

GitHub Actions / ragflow_tests

ruff (F841)

deepdoc/parser/mineru_parser.py:361:9: F841 Local variable `imgs` is assigned to but never used help: Remove assignment to unused variable `imgs`
poss = self.extract_positions(text)
if not poss:
if need_position:
Expand Down Expand Up @@ -416,7 +416,11 @@
)

positions = []
# Each entry is (PIL.Image, is_context) so overlay logic is decoupled from final index.
imgs_with_flags = []
poss_last_idx = len(poss) - 1
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — thank you for pointing that out.

The imgs = [] line has already been removed in the latest commit. The unused variable was identified and cleaned up to address the Ruff F841 warning.

CI should now pass cleanly, but please let me know if anything else needs attention.

for ii, (pns, left, right, top, bottom) in enumerate(poss):
is_context = ii == 0 or ii == poss_last_idx
right = left + max_width

if bottom <= top:
Expand All @@ -443,8 +447,9 @@
if x1 <= x0 or y1 <= y0:
continue
crop0 = img0.crop((x0, y0, x1, y1))
imgs.append(crop0)
if 0 < ii < len(poss) - 1:
self.logger.debug(f"[MinerU] crop: page={pns[0]} coords=({x0},{y0},{x1},{y1}) is_context={is_context} page_count={page_count}")
imgs_with_flags.append((crop0, is_context))
if 0 < ii < poss_last_idx:
positions.append((pns[0] + self.page_from, x0, x1, y0, y1))

bottom -= img0.size[1]
Expand All @@ -463,25 +468,25 @@
bottom -= page.size[1]
continue
cimgp = page.crop((x0, y0, x1, y1))
imgs.append(cimgp)
if 0 < ii < len(poss) - 1:
imgs_with_flags.append((cimgp, is_context))
if 0 < ii < poss_last_idx:
positions.append((pn + self.page_from, x0, x1, y0, y1))
bottom -= page.size[1]

if not imgs:
if not imgs_with_flags:
if need_position:
return None, None
return

height = 0
for img in imgs:
for img, _ in imgs_with_flags:
height += img.size[1] + GAP
height = int(height)
width = int(np.max([i.size[0] for i in imgs]))
width = int(np.max([i.size[0] for i, _ in imgs_with_flags]))
pic = Image.new("RGB", (width, height), (245, 245, 245))
height = 0
for ii, img in enumerate(imgs):
if ii == 0 or ii + 1 == len(imgs):
for img, is_context in imgs_with_flags:
if is_context:
img = img.convert("RGBA")
overlay = Image.new("RGBA", img.size, (0, 0, 0, 0))
overlay.putalpha(128)
Expand Down
Loading