Skip to content

Fix: The text field resizing function in the knowledge block creation…#14212

Open
stardyun wants to merge 2 commits intoinfiniflow:mainfrom
stardyun:hotfix/textarea_20260419
Open

Fix: The text field resizing function in the knowledge block creation…#14212
stardyun wants to merge 2 commits intoinfiniflow:mainfrom
stardyun:hotfix/textarea_20260419

Conversation

@stardyun
Copy link
Copy Markdown

@stardyun stardyun commented Apr 19, 2026

… modal

  • Add vertical resizing functionality for the text field

What problem does this PR solve?

Fix the issue where the text content of the knowledge base editing parsing block is too long to scroll.

image

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

… modal

- Add vertical resizing functionality for the text field
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 19, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 19, 2026

📝 Walkthrough

Walkthrough

A minor UI configuration change was made to a textarea component in the knowledge chunk modal. The Textarea element for content_with_weight now includes a resize="vertical" property alongside its existing autoSize configuration, allowing users to manually adjust the textarea height.

Changes

Cohort / File(s) Summary
Modal Textarea Configuration
web/src/pages/chunk/parsed-result/add-knowledge/components/knowledge-chunk/components/chunk-creating-modal/index.tsx
Added resize="vertical" property to the content_with_weight textarea field, enabling manual vertical resizing while preserving existing auto-size behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A humble tweak, so light and small,
The textarea now responds to all—
Resize vertical, oh what a delight!
Users stretch their thoughts just right.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding text field resizing functionality to the knowledge block creation modal.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description includes a clear problem statement and correctly identifies the change type as a Bug Fix, but lacks detail about the specific solution and provides only a visual reference.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@stardyun
Copy link
Copy Markdown
Author

📝 Walkthrough

Walkthrough

A minor UI configuration change was made to a textarea component in the knowledge chunk modal. The Textarea element for content_with_weight now includes a resize="vertical" property alongside its existing autoSize configuration, allowing users to manually adjust the textarea height.

Changes

Cohort / File(s) Summary
Modal Textarea Configuration
web/src/pages/chunk/parsed-result/add-knowledge/components/knowledge-chunk/components/chunk-creating-modal/index.tsx Added resize="vertical" property to the content_with_weight textarea field, enabling manual vertical resizing while preserving existing auto-size behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A humble tweak, so light and small,
The textarea now responds to all—
Resize vertical, oh what a delight!
Users stretch their thoughts just right.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request description addresses the core problem and identifies the change type, but lacks comprehensive details about the implementation and testing approach. Expand the description to explain how the vertical resizing is implemented (e.g., the specific configuration added), the user impact, and any testing performed to verify the fix resolves the scrolling issue.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding text field resizing functionality to the knowledge block creation modal.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

Solved

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

Tip

For best results, initiate chat on the files or code changes.

@stardyun Thanks for confirming! The fix looks straightforward — adding resize="vertical" to the textarea enables manual vertical resizing while the existing autoSize behavior continues to handle automatic height adjustments. The change is clean and minimal.


🧠 Learnings used
Learnt from: CR
Repo: infiniflow/ragflow PR: 0
File: web/CLAUDE.md:0-0
Timestamp: 2026-04-14T08:34:20.682Z
Learning: Applies to web/**/*.{tsx,ts,jsx,js} : When fixing CSS/layout issues (especially flex truncation, ellipsis, or element sizing), always inspect the full parent hierarchy for `flex-shrink`, `min-width`, and `overflow` constraints before applying fixes like `min-w-0`. Before editing, explain: (1) the full flex/container hierarchy from the target element up to the nearest non-flex ancestor, (2) what constraint is actually causing the bug, and (3) how the proposed fix addresses that root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants