Skip to content

fix user login history link in logins.foil.php#989

Open
chris240189 wants to merge 1 commit into
inex:release-v7from
bcix:fix_login_history
Open

fix user login history link in logins.foil.php#989
chris240189 wants to merge 1 commit into
inex:release-v7from
bcix:fix_login_history

Conversation

@chris240189

Copy link
Copy Markdown

[BF] Summary of fix - fixes #988

Comparing
resources/views/customer/overview-tabs/logins.foil.php
with
resources/views/customer/overview-tabs/users.foil.php

I have found that the login History link uses [ 'id' => $c2u->id ] and not [ 'id' => $c2u->user_id ]
This PR fixes that.

In addition to the above, I have:

  • ensured unit tests all run without error
  • ran psalm and corrected any static analysis issues
  • ensured all relevant template output is escaped to avoid XSS attached with <?= $t->ee( $data ) ?> or equivalent
  • ensured appropriate checks against user privilege / resources accessed
  • API calls (particular for add/edit/delete/toggle) are not implemented with GET and use CSRF tokens to avoid CSRF attacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant