Skip to content

[BUGFIX] sync test for fields to update with config #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sfsmfc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUGFIX] sync test for fields to update with config #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 33 additions & 13 deletions Classes/Domain/Service/AlternativeService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,18 +69,36 @@ protected function getLanguagesToUpdate(array $properties, File $image): array

protected function updateMetadata(int $uid, array $labels): void
{
$connection = GeneralUtility::makeInstance(ConnectionPool::class)->getConnectionForTable(self::TABLE);
$connection->update(
self::TABLE,
[
'title' => $labels['title'],
'description' => $labels['description'],
'alternative' => $labels['alternativeText'],
],
[
'uid' => $uid,
]
);
$fieldsToUpdate = $this->getUpdatesFields($labels);
if ($fieldsToUpdate !== []) {
$connection = GeneralUtility::makeInstance(ConnectionPool::class)->getConnectionForTable(self::TABLE);
$connection->update(
self::TABLE,
$fieldsToUpdate,
[
'uid' => $uid,
]
);
}
}

protected function getUpdatesFields(array $labels): array
{
$fields = [];

if (ConfigurationUtility::getConfigurationByKey('setTitle') === '1') {
$fields['title'] = $labels['title'];
}

if (ConfigurationUtility::getConfigurationByKey('setDescription') === '1') {
$fields['description'] = $labels['description'];
}

if (ConfigurationUtility::getConfigurationByKey('setAlternative') === '1') {
$fields['alternative'] = $labels['alternativeText'];
}

return $fields;
}

protected function getOrCreateTranslation(int $metadataUid, int $languageUid, int $fileUid): array
Expand Down Expand Up @@ -165,6 +183,8 @@ protected function shouldUpdate(array $properties): bool
if ($this->enforce) {
return true;
}
return empty($properties['title']) && empty($properties['description']) && empty($properties['alternative']);
return (ConfigurationUtility::getConfigurationByKey('setTitle') !== '1' || empty($properties['title'])) &&
(ConfigurationUtility::getConfigurationByKey('setDescription') !== '1' || empty($properties['description'])) &&
(ConfigurationUtility::getConfigurationByKey('setAlternative') !== '1' || empty($properties['alternative']));
}
}