Skip to content

perf(web): optimize response sizes for initial page load #7594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mertalev merged 5 commits into from
Mar 6, 2024
Merged

perf(web): optimize response sizes for initial page load #7594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
80439f9
minify
mertalev Mar 3, 2024
d7fa988
fix
mertalev Mar 3, 2024
d256bd1
redundant config
mertalev Mar 3, 2024
ad1449b
use webp image for memory lane
mertalev Mar 3, 2024
5b8cbf0
remove compression
mertalev Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions web/src/lib/components/photos-page/asset-grid.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import type { AlbumResponseDto, AssetResponseDto } from '@immich/sdk';
import { DateTime } from 'luxon';
import { createEventDispatcher, onDestroy, onMount } from 'svelte';
import AssetViewer from '../asset-viewer/asset-viewer.svelte';
import IntersectionObserver from '../asset-viewer/intersection-observer.svelte';
import Portal from '../shared-components/portal/portal.svelte';
import Scrollbar from '../shared-components/scrollbar/scrollbar.svelte';
Expand Down Expand Up @@ -451,17 +450,19 @@

<Portal target="body">
{#if $showAssetViewer}
<AssetViewer
{withStacked}
{assetStore}
asset={$viewingAsset}
{isShared}
{album}
on:previous={handlePrevious}
on:next={handleNext}
on:close={handleClose}
on:action={({ detail: action }) => handleAction(action.type, action.asset)}
/>
{#await import('../asset-viewer/asset-viewer.svelte') then AssetViewer}
Comment thread
martabal marked this conversation as resolved.
<AssetViewer.default
{withStacked}
{assetStore}
asset={$viewingAsset}
{isShared}
{album}
on:previous={handlePrevious}
on:next={handleNext}
on:close={handleClose}
on:action={({ detail: action }) => handleAction(action.type, action.asset)}
/>
{/await}
{/if}
</Portal>

Expand Down
2 changes: 1 addition & 1 deletion web/src/lib/components/photos-page/memory-lane.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
>
<img
class="h-full w-full rounded-xl object-cover"
src={getAssetThumbnailUrl(memory.assets[0].id, ThumbnailFormat.Jpeg)}
src={getAssetThumbnailUrl(memory.assets[0].id, ThumbnailFormat.Webp)}
alt={`Memory Lane ${getAltText(memory.assets[0])}`}
draggable="false"
/>
Expand Down