Assorted optimizations for GStreamer's image-rs plugin#2907
Draft
amyspark wants to merge 2 commits intoimage-rs:version-0.25from
Draft
Assorted optimizations for GStreamer's image-rs plugin#2907amyspark wants to merge 2 commits intoimage-rs:version-0.25from
amyspark wants to merge 2 commits intoimage-rs:version-0.25from
Conversation
fintelia
reviewed
Apr 11, 2026
|
|
||
| /// Return the ICC profile's name as embedded in the image. | ||
| /// | ||
| /// For formats that don't store embedded profiles with separate names this function should always return `Ok(None)`. |
Contributor
There was a problem hiding this comment.
Are there formats other than PNG which do store names for the embedded profiles?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a MR to add a few things for feature parity in my GStreamer reader plugin:
iCCPchunk's profile nameread_imageBoth require upstream work, so marking as draft until those are landed: image-rs/image-png#679, mozilla/mp4parse-rust#446