Fix huerotate clamping to support subpixel types other than u8, f32, and f64#2860
Open
RunDevelopment wants to merge 2 commits intoimage-rs:mainfrom
Open
Fix huerotate clamping to support subpixel types other than u8, f32, and f64#2860RunDevelopment wants to merge 2 commits intoimage-rs:mainfrom
huerotate clamping to support subpixel types other than u8, f32, and f64#2860RunDevelopment wants to merge 2 commits intoimage-rs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clamping done by
huerotateandhuerotate_in_placeassumedu8and was incorrect for all primitives exceptu8,f32, andf64.Unrelated, it is really wasteful to do all calculations in
f64for subpixel types likeu8andu16.