Change visibility of the constructor of DomainMapper#100
Open
inacho wants to merge 1 commit intoiluwatar:masterfrom
Open
Change visibility of the constructor of DomainMapper#100inacho wants to merge 1 commit intoiluwatar:masterfrom
inacho wants to merge 1 commit intoiluwatar:masterfrom
Conversation
Change visibility of the constructor of DomainMapper to public, so when using the urm core as a dependency I am able to generate diagrams from a list of classes
iluwatar
requested changes
Dec 28, 2022
Owner
iluwatar
left a comment
iluwatar
left a comment
There was a problem hiding this comment.
The constructor is purposefully not public. Please introduce a new overloaded factory method create that suits your needs.
Owner
|
Please rebase this branch on top of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change visibility of the constructor of DomainMapper to public, so when using the urm core as a dependency I am able to generate diagrams from a list of classes