Skip to content

Remove obsolete/harmful onClick logic from Thumbnail. #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sznowicki wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove obsolete/harmful onClick logic from Thumbnail. #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions qml/pages/SubscribedPage.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,6 @@ Page {
height: parent.height
fillMode: Image.PreserveAspectFit
imageUrl: post.thumbnail_url || ""
onClicked: delegate.openPost()
}

NsfwOverlay {
Expand Down Expand Up @@ -420,7 +419,6 @@ Page {
verticalCenter: parent.verticalCenter
rightMargin: Theme.paddingMedium
}
onClicked: delegate.openPost()
}

NsfwOverlay {
Expand Down
9 changes: 0 additions & 9 deletions qml/pages/Thumbnail.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ Image {
id: thumbnail

property url imageUrl
property bool interactive: true

width: Theme.iconSizeLarge
height: Theme.iconSizeLarge
Expand All @@ -28,12 +27,4 @@ Image {
if (status === Image.Error)
console.warn("Failed to load thumbnail:", imageUrl);
}

MouseArea {
anchors.fill: parent
enabled: thumbnail.interactive && !!imageUrl
onClicked: thumbnail.clicked()
}

signal clicked
}
Loading