Skip to content

BUG: fabi shim: convert IFAIL only when JOBZ = 'V' - #36

Merged
ilayn merged 1 commit into
ilayn:mainfrom
agriyakhetarpal:fix-fabi-shim-ifail-jobz
Sep 30, 2026
Merged

ilayn merged 1 commit into
ilayn:mainfrom
agriyakhetarpal:fix-fabi-shim-ifail-jobz

Conversation

@agriyakhetarpal

@agriyakhetarpal agriyakhetarpal commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Closes #35.

This PR changes several rules in scripts/generate_fortran_shim.py:

  • ifail rules are now conditioned on JOBZ; and
  • ?hsein's ifaill/ifailr rules are now conditioned on SIDE.

and four shim files are regenerated.

xref scipy/scipy#25618
xref scipy/scipy#25713

@ilayn

ilayn commented Sep 30, 2026

Copy link
Copy Markdown
Owner

Thanks @agriyakhetarpal for this I was still desperately triaging this with a weak tablet. Let me get it in.

@ilayn
ilayn merged commit ef9849b into ilayn:main Sep 30, 2026
9 checks passed
@agriyakhetarpal
agriyakhetarpal deleted the fix-fabi-shim-ifail-jobz branch September 30, 2026 17:41
@agriyakhetarpal

agriyakhetarpal commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor Author

Thanks @ilayn for the quick merge! As is tradition, could you please do a v0.01.5-pre release?

@ilayn

ilayn commented Sep 30, 2026

Copy link
Copy Markdown
Owner

Already done 😉

ilayn pushed a commit to scipy/scipy that referenced this pull request Oct 1, 2026
…apack v0.01.5-pre (#26319)

* MNT: Don't depend on pytest-split for Pyodide CI

* BLD: Update semicolon-lapack to 0.01.5-pre

Includes ilayn/semicolon-lapack#36

* TST: Undo WASM skip for `test_wrapper_module_collected`

xref gh-26267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fortran ABI shim writes IFAIL[0..M-1] even when JOBZ = 'N', overrunning callers that follow the LAPACK docs

2 participants