fix(core): harden command contracts for v1.3.2 - #25
Merged
Conversation
- replace the TBaseCommand downcast with an optional parameter receiver - deprecate non-functional completion callback APIs - add interface-only command regression coverage - update roadmap, documentation, changelog, and release metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Release v1.3.2 - Contract Hardening
Target Release: v1.3.2
Release Date: 2026-07-30
Summary
This PR delivers the
v1.3.2roadmap milestone by correcting the mismatchbetween the public
ICommandcontract and the runtime implementation, and byclearly deprecating the non-functional custom-completion callback methods.
It also adds the maintenance roadmap, regression coverage, current
documentation, release notes, and version metadata for the patch release.
Type of Change
Contract Correction
ICommandParameterReceivercapability.TBaseCommandimplement the receiver.ICommand-to-TBaseCommanddowncast with aSupports()capability check.CLI.Commandimplementation dependency fromCLI.Application.ICommandimplementation executes andreturns its exit code.
Completion Callback Deprecation
RegisterFlagValueCompletion()as deprecated.RegisterPositionalCompletion()as deprecated.Documentation and Versioning
ROADMAP.mdwith maintenance outcomes through v2.0.0.ICommandParameterReceiver.1.3.2changelog entry and comparison links.1.3.2.1.3.2.Compatibility
Existing
TBaseCommanddescendants require no changes. Existing applicationfactories, command registration calls, generated projects, and schema-version-1
manifests retain their behaviour.
Direct
ICommandimplementations no longer fail merely because they do notinherit from
TBaseCommand. The new receiver interface is optional.The deprecated custom-completion methods remain callable in 1.x but can emit
compiler warnings. Removing calls to them is behaviour-preserving because the
methods were already no-ops.
Verification
1.3.2.Release Readiness
1.3.2.After merge, create the
v1.3.2tag and publish the prepared release notes.