Skip to content

Refactor Source Generator#253

Open
igoravl wants to merge 58 commits into
mainfrom
refactor-src-gen
Open

Refactor Source Generator#253
igoravl wants to merge 58 commits into
mainfrom
refactor-src-gen

Update release notes

64b1be6
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 12, 2026 in 17s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 70 in CSharp/TfsCmdlets.SourceGenerators/PropertyInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegtP8bj0kFn1OSQ&open=AZ0xDegtP8bj0kFn1OSQ&pullRequest=253

Check warning on line 38 in CSharp/TfsCmdlets.SourceGenerators/MethodInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDeeSP8bj0kFn1ORj&open=AZ0xDeeSP8bj0kFn1ORj&pullRequest=253

Check warning on line 132 in CSharp/TfsCmdlets.Shared/Cmdlets/CmdletBase.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add logic to this catch clause or eliminate it and rethrow the exception automatically.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ1xNjevTQrzfiB8qrmK&open=AZ1xNjevTQrzfiB8qrmK&pullRequest=253

Check warning on line 54 in CSharp/TfsCmdlets.SourceGenerators/Generators/Controllers/ControllerInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDeekP8bj0kFn1ORl&open=AZ0xDeekP8bj0kFn1ORl&pullRequest=253

Check warning on line 160 in CSharp/TfsCmdlets.SourceGenerators/Generators/Cmdlets/CmdletInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of using this literal 'Parameter' 5 times.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDefMP8bj0kFn1OR0&open=AZ0xDefMP8bj0kFn1OR0&pullRequest=253

Check warning on line 32 in CSharp/TfsCmdlets.SourceGenerators/Extensions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All 'GetAttributeNamedValue' method overloads should be adjacent.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegjP8bj0kFn1OSN&open=AZ0xDegjP8bj0kFn1OSN&pullRequest=253

Check warning on line 19 in CSharp/TfsCmdlets.SourceGenerators/Extensions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All 'GetAttributeConstructorValue' method overloads should be adjacent.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegjP8bj0kFn1OSM&open=AZ0xDegjP8bj0kFn1OSM&pullRequest=253

Check warning on line 46 in CSharp/TfsCmdlets/Cmdlets/Git/RemoveGitRepository.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ1-1ZG3yfA2bFfvzi9Z&open=AZ1-1ZG3yfA2bFfvzi9Z&pullRequest=253

Check warning on line 313 in CSharp/TfsCmdlets.SourceGenerators/Generators/Controllers/ControllerInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDeekP8bj0kFn1ORm&open=AZ0xDeekP8bj0kFn1ORm&pullRequest=253

Check warning on line 9 in CSharp/TfsCmdlets.SourceGenerators/IsExternalInit.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty class, write its code or make it an "interface".

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDefoP8bj0kFn1OR3&open=AZ0xDefoP8bj0kFn1OR3&pullRequest=253

Check warning on line 207 in CSharp/TfsCmdlets.SourceGenerators/Generators/Controllers/ControllerInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'GenerateCredentialProperties' a static method.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDeekP8bj0kFn1ORq&open=AZ0xDeekP8bj0kFn1ORq&pullRequest=253

Check warning on line 174 in CSharp/TfsCmdlets.SourceGenerators/ClassInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'GetImportingConstructorArguments' a static method.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegBP8bj0kFn1OR8&open=AZ0xDegBP8bj0kFn1OR8&pullRequest=253

Check warning on line 318 in CSharp/TfsCmdlets/Cmdlets/WorkItem/AreasIterations/ClassificationNodeHelper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'destinationNode' is null on at least one execution path.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ1-NcNEK0fgB4uOIEV4&open=AZ1-NcNEK0fgB4uOIEV4&pullRequest=253

Check warning on line 45 in CSharp/TfsCmdlets.SourceGenerators/Generators/Controllers/ControllerInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDeekP8bj0kFn1ORk&open=AZ0xDeekP8bj0kFn1ORk&pullRequest=253

Check warning on line 197 in CSharp/TfsCmdlets/Cmdlets/WorkItem/AreasIterations/ClassificationNodeHelper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this method into two, one handling parameters check and the other handling the iterator.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ1-NcNEK0fgB4uOIEVz&open=AZ1-NcNEK0fgB4uOIEVz&pullRequest=253

Check warning on line 99 in CSharp/TfsCmdlets.SourceGenerators/HashCode.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the number of generic parameters in the 'HashCode.Combine' method to no more than the 3 authorized.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegMP8bj0kFn1OR_&open=AZ0xDegMP8bj0kFn1OR_&pullRequest=253

Check warning on line 47 in CSharp/TfsCmdlets.SourceGenerators/Extensions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this condition so that it does not always evaluate to 'False'.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegjP8bj0kFn1OSO&open=AZ0xDegjP8bj0kFn1OSO&pullRequest=253

Check failure on line 41 in CSharp/TfsCmdlets.SourceGenerators/ClassInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call from a constructor to the overridable 'GetCtorArgs' method.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegBP8bj0kFn1OR7&open=AZ0xDegBP8bj0kFn1OR7&pullRequest=253

Check warning on line 150 in CSharp/TfsCmdlets.SourceGenerators/HashCode.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the number of generic parameters in the 'HashCode.Combine' method to no more than the 3 authorized.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegMP8bj0kFn1OSB&open=AZ0xDegMP8bj0kFn1OSB&pullRequest=253

Check warning on line 1 in CSharp/TfsCmdlets.SourceGenerators/Analyzers/ClassMustBePartial.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDeffP8bj0kFn1OR2&open=AZ0xDeffP8bj0kFn1OR2&pullRequest=253

Check warning on line 69 in CSharp/TfsCmdlets.SourceGenerators/Extensions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegjP8bj0kFn1OSI&open=AZ0xDegjP8bj0kFn1OSI&pullRequest=253

Check warning on line 109 in CSharp/TfsCmdlets/Cmdlets/WorkItem/AreasIterations/ClassificationNodeHelper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 13 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ1-NcNEK0fgB4uOIEV0&open=AZ1-NcNEK0fgB4uOIEV0&pullRequest=253

Check warning on line 234 in CSharp/TfsCmdlets.SourceGenerators/Generators/Cmdlets/CmdletInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDefMP8bj0kFn1ORz&open=AZ0xDefMP8bj0kFn1ORz&pullRequest=253

Check warning on line 162 in CSharp/TfsCmdlets.SourceGenerators/Extensions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegjP8bj0kFn1OSJ&open=AZ0xDegjP8bj0kFn1OSJ&pullRequest=253

Check warning on line 123 in CSharp/TfsCmdlets.SourceGenerators/HashCode.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the number of generic parameters in the 'HashCode.Combine' method to no more than the 3 authorized.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegMP8bj0kFn1OSA&open=AZ0xDegMP8bj0kFn1OSA&pullRequest=253