Repository navigation
Replace deprecated atomic update API for Rust 1.99 - #330
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI runner now uses Rust 1.99, which deprecates
Atomic::fetch_update. Workspace Clippy treats that deprecation as an error, blocking otherwise unrelated fixes such as #329.Replace the two shell generation-counter calls and the compositor's injected queue-failure counter call with
try_update. This is a direct API rename: Rust's implementation forwardsfetch_updatetotry_update(standard-library source).try_updatehas been stable since Rust 1.95.The closures, memory orderings, returned previous values, overflow panics, and zero-budget behavior remain identical. No new test is needed for a direct alias replacement; existing generation/stale-menu tests and the injected-failure counter test cover these callers. The polkit changes remain in #329.
Validation
cargo +1.99.0 test --locked -p chonk-shell --lib: 298 passed, 3 ignored.cargo +1.99.0 test --locked -p wm-wayland --lib injected_queue_failures_escalate_once_after_the_threshold_and_not_inside_the_backoff: passed.cargo +1.99.0 clippy --locked --workspace --all-targets --no-deps -- -D warnings -D clippy::disallowed_methods -D clippy::disallowed_types -D clippy::undocumented_unsafe_blocks: passed.git diff --check: passed.All Cargo commands above used an isolated target directory. Workspace tests, X11 runtime checks, full Wayland end-to-end tests, documentation, dependency audit, and Omarchy installation passed in CI. The Debian packaging workflow also passed.