Skip to content

Module#295

Closed
ichiban wants to merge 15 commits intomainfrom
module
Closed

Module#295
ichiban wants to merge 15 commits intomainfrom
module

Conversation

@ichiban
Copy link
Copy Markdown
Owner

@ichiban ichiban commented May 20, 2023

#292

This PR implements a SICStus style module system.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2023

Codecov Report

Attention: Patch coverage is 66.47196% with 287 lines in your changes missing coverage. Please review.

Project coverage is 95.65%. Comparing base (c682cd3) to head (9673e7f).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
engine/builtin.go 69.27% 106 Missing ⚠️
engine/text.go 58.33% 88 Missing and 7 partials ⚠️
engine/module.go 3.38% 57 Missing ⚠️
engine/vm.go 70.73% 11 Missing and 1 partial ⚠️
engine/clause.go 61.90% 7 Missing and 1 partial ⚠️
engine/term.go 82.60% 4 Missing ⚠️
interpreter.go 96.42% 2 Missing and 2 partials ⚠️
engine/parser.go 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
- Coverage   99.21%   95.65%   -3.57%     
==========================================
  Files          23       24       +1     
  Lines        7272     7777     +505     
==========================================
+ Hits         7215     7439     +224     
- Misses         51      321     +270     
- Partials        6       17      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ichiban
Copy link
Copy Markdown
Owner Author

ichiban commented Oct 7, 2024

This PR lacks the concept of type-in module #292 (comment)

#307 has type-in module and is preferable.

@ichiban ichiban closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant