Skip to content

Refactor write_benchmark_json to comply with github-action-benchmark format and ensure time series creation#948

Merged
thehrh merged 3 commits into
masterfrom
fix/benchmark_json_format
Jun 10, 2026
Merged

Refactor write_benchmark_json to comply with github-action-benchmark format and ensure time series creation#948
thehrh merged 3 commits into
masterfrom
fix/benchmark_json_format

Conversation

@thehrh

@thehrh thehrh commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Turns out the workflow failed because the script had created dictionary entries when only a simple list of results was allowed.

Another problem which appeared in my branch was the automatic removal of the previous benchmarking results in the gh-pages branch by the documentation workflow.

As a result, I've adapted the documentation workflow, on the one hand, to output to docs, not the root directory, of gh-pages, and, more importantly, configured it to keep_files. This way, dev/bench/data.js will not get deleted and instead will be extended.

It just means we will need to set the PISA (docs) URL in the right column to icecube.github.io/pisa/docs (leaving the Pages source at / (root) in settings.

Also, ideally before this PR is merged, we should manually delete the gh-pages branch once so that the files currently in its root directory are removed.

In the future, the benchmark time series will then be extended as long as dev/bench/data.js in gh-pages isn't deleted. If —for some reason—it does get deleted at some point without there being a backup, the time series will just start anew.

Finally, an entry point for the benchmarking script is added to setup.py.

@thehrh thehrh added this to the 4.3 milestone Jun 5, 2026
@thehrh thehrh requested a review from JanWeldert June 5, 2026 22:23
@thehrh thehrh added the bug label Jun 5, 2026
@thehrh thehrh changed the title Refactor write_benchmark_json to output only results (actually comply with github-action-benchmark format) Refactor write_benchmark_json to comply with github-action-benchmark format and ensure time series creation Jun 6, 2026
@thehrh thehrh merged commit 2c5f2b2 into master Jun 10, 2026
2 checks passed
@thehrh thehrh deleted the fix/benchmark_json_format branch June 10, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants