Skip to content

test: reviewdog/action-shellcheck inline annotations demo#111

Open
iav wants to merge 1 commit into
audit/shellcheck-comparisonfrom
test/shellcheck-reviewdog-demo
Open

test: reviewdog/action-shellcheck inline annotations demo#111
iav wants to merge 1 commit into
audit/shellcheck-comparisonfrom
test/shellcheck-reviewdog-demo

Conversation

@iav
Copy link
Copy Markdown
Owner

@iav iav commented May 11, 2026

Fork-internal demo PR. Do not merge.

Exercises the new maintenance-lint-scripts-reviewdog.yml workflow added on the audit/shellcheck-comparison branch. The added .github/demo-reviewdog-shellcheck.sh contains an SC1073/SC1072 parser-error pair which reviewdog/action-shellcheck should surface as inline review-comments on this PR's diff.

Expected:

  • Shell script analysis (reviewdog) check appears in the PR status list
  • 2 inline review comments on lines 21–22 of .github/demo-reviewdog-shellcheck.sh
  • Workflow exits non-zero due to fail_level: error

ls $(echo /tmp)

# SC1073 — parser error: unmatched $( (error)
broken=$(echo hello
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
The mentioned syntax error was in this variable assignment. SC1009

ls $(echo /tmp)

# SC1073 — parser error: unmatched $( (error)
broken=$(echo hello
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
Couldn't parse this command expansion. Fix to allow more checks. SC1073

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
Expected end of $(..) expression. Fix any mentioned problems and try again. SC1072

https://github.com/iav/armbian/blob/1927a9b2f86b434698948281d92c28c73b963810/.github/demo-reviewdog-shellcheck.sh#L22

@iav iav force-pushed the audit/shellcheck-comparison branch from ff5315e to eda6beb Compare May 11, 2026 14:38
@iav iav force-pushed the test/shellcheck-reviewdog-demo branch from 1927a9b to 9529b1d Compare May 11, 2026 14:38
@iav iav force-pushed the audit/shellcheck-comparison branch from eda6beb to de1ee88 Compare May 11, 2026 14:42
@iav iav force-pushed the test/shellcheck-reviewdog-demo branch from 9529b1d to 3eadafe Compare May 11, 2026 14:42
Not for merge — used to exercise reviewdog/action-shellcheck PR-review
annotations on the new maintenance-lint-scripts-reviewdog.yml workflow.
File mixes info / warning / error severities so the level=error gate
can be observed in action.

Assisted-by: Claude:claude-opus-4.7
@iav iav force-pushed the audit/shellcheck-comparison branch from de1ee88 to 5e5106e Compare May 11, 2026 14:55
@iav iav force-pushed the test/shellcheck-reviewdog-demo branch from 3eadafe to 17116a8 Compare May 11, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant