Honor CMAKE_DEBUG_POSTFIX when combining static libraries for debug build of cpp client - #209
Open
nbmaltais wants to merge 1 commit into
Open
Honor CMAKE_DEBUG_POSTFIX when combining static libraries for debug build of cpp client#209nbmaltais wants to merge 1 commit into
nbmaltais wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: Variable PROJECTAIRSIM_CPP_CLIENT_FINAL_LIB in cmake file uses CMAKE_DEBUG_POSTFIX .
Fixes: ProjectAirSimCppClientConfig.cmake.in uses library name with CMAKE_DEBUG_POSTFIX for debug configuration.
About
When building and installing the cpp client on windows with MSVC, the final library has the same name in debug and release.
Normaly, setting CMAKE_DEBUG_POSTFIX would fix the problem but the final library is built with a custom command that does not honor the postfix.
This patch fixes this.
How Has This Been Tested?
Build and installed with the following command on a windows computer using MCVS:
cd client\cpp
cmake -B build -S . -DCMAKE_DEBUG_POSTFIX=d
cmake --build .\build --config Debug
cmake --build .\build --config Release
cmake --install .\build --config Debug --prefix .\installed\cppclient
cmake --install .\build --config Release--prefix .\installed\cppclient
In the install folder, we get both ProjectAirSimCppClient.lib and ProjectAirSimCppClientd.lib
Tested importing the lib from another project and compiled in debug and release.
Screenshots and videos (if appropriate):