Repository navigation
server: Rename JudgelsService* to JudgelsApi* and split ServiceUtils - #1029
Merged
Merged
Conversation
After judgels.service became judgels.core, a few classes still carried the old "service" name. ServiceUtils also mixed two unrelated things: request checks that nearly every resource calls, and file response builders that only a few call. Rename the JudgelsService* error classes to JudgelsApi*, and split ServiceUtils into JudgelsRequestChecks and JudgelsResponseBuilders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
judgels.servicebecamejudgels.core(#1028), a few classes still carried the old "service" name.ServiceUtilsalso mixed two unrelated things: request checks that nearly every resource calls, and file response builders that only a few call.Rename the
JudgelsService*error classes toJudgelsApi*, and splitServiceUtilsin two. No method body, package or JSON field changes.JudgelsServiceException→JudgelsApiExceptionandJudgelsServiceError→JudgelsApiError, injudgels.core.api. They are the error an API caller sees: an HTTP status, a message and args.JudgelsServiceExceptionMapper→JudgelsApiExceptionMapper, and the integration-test helperJudgelsServiceErrorDecoder→JudgelsApiErrorDecoder.ServiceUtils→JudgelsRequestChecks(checkFound,checkAllowed) andJudgelsResponseBuilders(buildDownloadResponse,buildMediaResponse), both injudgels.core.The Gradle module
judgels-service-corekeeps its name.