Repository navigation
fix(ansible): take the chrome-devtools MCP path from the linked command - #1342
Merged
Merged
Conversation
chrome-devtools-mcp 1.13.0 moved its entry from build/src/bin to out/Default/gen/src/bin, so the pinned path stopped existing and every worker image build failed its verify step. The installer already links ~/.local/bin/chrome-devtools-mcp from the package's own bin field, so the path now follows any release.
i098
force-pushed
the
fm/cf-chrome-mcp-path
branch
from
November 12, 2026 04:45
d364d29 to
43aef69
Compare
i098
marked this pull request as ready for review
November 12, 2026 04:59
i098
commented
Nov 12, 2026
i098
left a comment
Owner
Author
There was a problem hiding this comment.
Validation review for head 43aef69.
- Checked: the change swaps the pinned chrome-devtools MCP entry file for the installer-linked command, with the two configuration tests, the dependency doc and the changelog fragment.
- Review step: one documentation finding, fixed in the branch. One finding on the
currentlink was kept, with the reason stated in the run. - Test step: the full suite listed 20 failing tests. A one-at-a-time comparison of main and this head gave the same result on both: 3 fail on main too (named in the PR body), 17 pass alone. No failure is specific to this head, and the change touches no messaging code.
- CI step: a changelog link was corrected, then the branch was rebased onto main.
- Result: all required checks pass on this head, including
worker image behavior smoke, the check that is red on main and that this change repairs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1341
Summary
Take the chrome-devtools MCP entry path from the command the installer links, so a release that moves its own entry file no longer breaks the worker image build.
What changed and why
current/node_modules/chrome-devtools-mcp/build/src/bin/...path with{{ crewship_local_bin }}/chrome-devtools-mcp, the linklink_package_binswrites from the package's ownbinfield.Test evidence
uv run --group dev ruff check tests/test_configuration.py: clean.uv run --group dev python -m pytest tests/test_configuration.py -k 'new_chrome_devtools_mcp_release or board_environment_reaches_new_shells': 2 passed.bun add chrome-devtools-mcp@1.13.0, thenprovisions.link_package_binswrites~/.local/bin/chrome-devtools-mcp->.../node_modules/chrome-devtools-mcp/out/Default/gen/src/bin/chrome-devtools-mcp.js; that command answers--versionwith1.13.0.ansible-playbook --syntax-check -i localhost, blueprint/ansible/site.yml: clean.d14dee7d(attributed one test at a time on both revisions, 0 head-only):tests/test_imessage_session.py::test_thread_reply_goes_to_the_mate_that_sent_the_quoted_bubble_when_two_mates_sent_the_same_text,tests/test_imessage_session.py::test_thread_reply_to_a_mates_bubble_goes_to_that_mate_even_after_a_restart,tests/test_imessage_v2.py::test_work_request_keeps_typing_until_the_final_answer.The first two are stale inbox expectations that PR fix(blueprint): render the stow path into the shipped brief include #1340 rewrites; this PR touches no iMessage code.
worker image behavior smokeis the check that failed before this change; it is the check this PR fixes.Checklist
fix(provisions): check the digest before install.uv run pytest).uv run ruff check).--syntax-check).launch→launch=changed=0on the second run.changelog.d/<issue>.<type>.md(not aCHANGELOG.mdedit), or theno changeloglabel.