Skip to content

fix(ansible): take the chrome-devtools MCP path from the linked command - #1342

Merged
i098 merged 3 commits into
mainfrom
fm/cf-chrome-mcp-path
Nov 12, 2026
Merged

i098 merged 3 commits into
mainfrom
fm/cf-chrome-mcp-path

Conversation

@i098

@i098 i098 commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Closes #1341

Summary

Take the chrome-devtools MCP entry path from the command the installer links, so a release that moves its own entry file no longer breaks the worker image build.

What changed and why

  • Replace the pinned current/node_modules/chrome-devtools-mcp/build/src/bin/... path with {{ crewship_local_bin }}/chrome-devtools-mcp, the link link_package_bins writes from the package's own bin field.
  • Keep the managed environment text unchanged between releases, as the comment above the variable promises.
  • Update the two configuration tests that asserted the old literal path.
  • Add the changelog fragment.

Test evidence

  • uv run --group dev ruff check tests/test_configuration.py: clean.
  • uv run --group dev python -m pytest tests/test_configuration.py -k 'new_chrome_devtools_mcp_release or board_environment_reaches_new_shells': 2 passed.
  • Proof on the released package: bun add chrome-devtools-mcp@1.13.0, then provisions.link_package_bins writes ~/.local/bin/chrome-devtools-mcp -> .../node_modules/chrome-devtools-mcp/out/Default/gen/src/bin/chrome-devtools-mcp.js; that command answers --version with 1.13.0.
  • ansible-playbook --syntax-check -i localhost, blueprint/ansible/site.yml: clean.
  • The full suite has 3 failures that also fail on main d14dee7d (attributed one test at a time on both revisions, 0 head-only):
    tests/test_imessage_session.py::test_thread_reply_goes_to_the_mate_that_sent_the_quoted_bubble_when_two_mates_sent_the_same_text,
    tests/test_imessage_session.py::test_thread_reply_to_a_mates_bubble_goes_to_that_mate_even_after_a_restart,
    tests/test_imessage_v2.py::test_work_request_keeps_typing_until_the_final_answer.
    The first two are stale inbox expectations that PR fix(blueprint): render the stow path into the shipped brief include #1340 rewrites; this PR touches no iMessage code.
  • worker image behavior smoke is the check that failed before this change; it is the check this PR fixes.

Checklist

  • One concern in this PR.
  • The title uses the commit format, for example fix(provisions): check the digest before install.
  • Tests pass (uv run pytest).
  • Lint clean (uv run ruff check).
  • Ansible syntax clean (--syntax-check).
  • Idempotent: launch → launch = changed=0 on the second run.
  • A changelog fragment, changelog.d/<issue>.<type>.md (not a CHANGELOG.md edit), or the no changelog label.

i098 added 3 commits November 12, 2026 03:47
chrome-devtools-mcp 1.13.0 moved its entry from build/src/bin to
out/Default/gen/src/bin, so the pinned path stopped existing and every
worker image build failed its verify step.

The installer already links ~/.local/bin/chrome-devtools-mcp from the
package's own bin field, so the path now follows any release.
@i098
i098 force-pushed the fm/cf-chrome-mcp-path branch from d364d29 to 43aef69 Compare November 12, 2026 04:45
@i098
i098 marked this pull request as ready for review November 12, 2026 04:59

@i098 i098 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation review for head 43aef69.

  • Checked: the change swaps the pinned chrome-devtools MCP entry file for the installer-linked command, with the two configuration tests, the dependency doc and the changelog fragment.
  • Review step: one documentation finding, fixed in the branch. One finding on the current link was kept, with the reason stated in the run.
  • Test step: the full suite listed 20 failing tests. A one-at-a-time comparison of main and this head gave the same result on both: 3 fail on main too (named in the PR body), 17 pass alone. No failure is specific to this head, and the change touches no messaging code.
  • CI step: a changelog link was corrected, then the branch was rebased onto main.
  • Result: all required checks pass on this head, including worker image behavior smoke, the check that is red on main and that this change repairs.

@i098
i098 merged commit 130c8a6 into main Nov 12, 2026
19 of 20 checks passed
@i098
i098 deleted the fm/cf-chrome-mcp-path branch November 12, 2026 05:01
@github-project-automation github-project-automation Bot moved this from Todo to Done in Crewship roadmap Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Worker image build fails after chrome-devtools-mcp 1.13.0 moved its entry point

1 participant