Bench fcs zkp by Effi-S · Pull Request #1373 · hyperledger-labs/fabric-token-sdk

Effi-S · 2026-02-18T14:07:44Z

We are adding ZKP Benchmarking to test overhead of FSC nodes on TPS

AkramBitar · 2026-04-16T09:31:22Z

@@ -0,0 +1,36 @@
+# Setting up 2 nodes Benchmarking on 2 Severs
+
+To setup AWS EC2 nodes See: [AWS Setup 2 Machines](../../../token/core/zkatdlog/nogh/v1/validator/bench/transfer_service/aws_setup_2_machines.md)


Make it general and say if we want to run the benchmark on AWS: ... setting link.

Is that setting relevant for AWS only?

setting_up_nodes.md is general and links to aws_setup_2_machines.md which is AWS specific setup.
Some settings where used on AWS only - alot of overlap though

To setup AWS EC2 nodes See: [AWS Setup 2 Machines]

Setting up 2 nodes Benchmarking on 2 Severs (General)

AkramBitar · 2026-04-16T11:47:33Z

@@ -0,0 +1,49 @@
+/*


What is the deference between transfer_zk_only and transfer_service?

if we need transfer_zk_only .. then we need to describe it un the docs and indicated the deferences between these two.

Let's discuss this

Removed this bench

AkramBitar

LGTM.
Added two comments.
Please resolve the comments and rebase

AkramBitar · 2026-04-20T21:58:33Z

 	}
 }

+func BenchmarkTranferRegression2in2out(b *testing.B) {


I that test described in on of the documentation files?
if not maybe t add it to this doc: docs/drivers/benchmark/core/dlognogh/dlognogh_regression.md
by the way we need this test? is it the same as the parallel regression test?
Do we have it in our graphs and results that we reported?

adecaro · 2026-04-23T12:36:02Z

+//       f. TransferApplicationDataValidate [validates metadata]
+//   4. After all validators pass, it checks that all metadata have been validated
+
+func (q *TransferServiceView) Call(viewCtx view.Context) (interface{}, error) {


TransferServiceView is misleading as a name cause a token request validation is exeuted by the view. Please, rename it.

renamed TransferServiceView to TransferServiceTokenValidationView

adecaro

Thanks @Effi-S , I left some preliminary comments.
I think this benchmark infrastructure should be move elsewhere, not under token/core/zkatdlog/nogh/v1/validator. Perhaps, under cmd/benchmarking

Signed-off-by: Effi-S <effi.szt@gmail.com>

AkramBitar · 2026-05-12T10:33:48Z

Hi, @adecaro I addressed your comments. Please let me know if you have more.

Effi-S force-pushed the bench-fcs-zkp branch from cae6da9 to 1474e0e Compare February 18, 2026 14:19

Effi-S mentioned this pull request Feb 24, 2026

Run ZKP Verification benchamark on Single endorser Perf Extended #1398

Open

AkramBitar linked an issue Feb 24, 2026 that may be closed by this pull request

Run ZKP Verification benchamark on Single endorser Perf Extended #1398

Open

AkramBitar added this to the Q1/26 milestone Feb 24, 2026

AkramBitar added the benchmark label Feb 24, 2026

AkramBitar assigned Effi-S Feb 24, 2026

AkramBitar marked this pull request as draft February 24, 2026 10:53

Effi-S force-pushed the bench-fcs-zkp branch 3 times, most recently from eefc01a to 2dc9e5f Compare February 26, 2026 12:44

github-code-quality Bot found potential problems Mar 2, 2026

View reviewed changes

Comment thread cmd/benchmarking/plotly_plot_node.py Fixed

github-code-quality Bot found potential problems Mar 3, 2026

View reviewed changes

Comment thread cmd/benchmarking/plotly_plot_node.py Fixed

Effi-S force-pushed the bench-fcs-zkp branch 2 times, most recently from 6029aa0 to b8e8a5d Compare March 5, 2026 16:39

github-code-quality Bot found potential problems Mar 9, 2026

View reviewed changes

Comment thread cmd/benchmarking/plotly_plot_node.py Fixed

Effi-S force-pushed the bench-fcs-zkp branch 2 times, most recently from 3c5bbfd to b1591b6 Compare March 12, 2026 12:43

github-code-quality Bot found potential problems Mar 26, 2026

View reviewed changes

Comment thread cmd/benchmarking/plotly_plot_node.py Fixed

Effi-S force-pushed the bench-fcs-zkp branch from 27fe084 to efc808e Compare March 26, 2026 09:35

adecaro modified the milestones: Q1/26, Q2/26 Apr 2, 2026

This was linked to issues Apr 6, 2026

Run ZKP benchmarks on more physical cores #1380

Open

ZKP Benchmarking in Single Endorser Node #1396

Open

AkramBitar modified the milestones: Q2/26, Q3/26 Apr 6, 2026

Effi-S force-pushed the bench-fcs-zkp branch from 0d2c1c5 to d6603ac Compare April 14, 2026 12:52

AkramBitar requested changes Apr 16, 2026

View reviewed changes

Effi-S force-pushed the bench-fcs-zkp branch from ab67987 to 474a0c2 Compare April 20, 2026 13:57

AkramBitar approved these changes Apr 20, 2026

View reviewed changes

Effi-S force-pushed the bench-fcs-zkp branch from 0db262f to c847339 Compare April 23, 2026 11:03

adecaro reviewed Apr 23, 2026

View reviewed changes

Comment thread token/core/zkatdlog/nogh/v1/validator/regression/regression_test.go Outdated

adecaro reviewed Apr 23, 2026

View reviewed changes

Comment thread token/core/zkatdlog/nogh/v1/validator/bench/transfer_service/transfer_service_bench.go Outdated

adecaro reviewed Apr 23, 2026

View reviewed changes

Comment thread cmd/transfer_service/transfer_service_bench.go

adecaro requested changes Apr 23, 2026

View reviewed changes

adecaro reviewed Apr 23, 2026

View reviewed changes

Comment thread docs/drivers/benchmark/transfer_service_benchmark.md Outdated

Effi-S force-pushed the bench-fcs-zkp branch from 4698264 to 22b8ba1 Compare April 26, 2026 08:49

Effi-S requested a review from adecaro April 26, 2026 08:52

adecaro reviewed Apr 27, 2026

View reviewed changes

Comment thread docs/drivers/benchmark/transfer_service_benchmark.md Outdated

adecaro reviewed Apr 27, 2026

View reviewed changes

Comment thread token/core/zkatdlog/nogh/v1/validator/regression/regression_test.go Outdated

adecaro force-pushed the bench-fcs-zkp branch from 479fdde to 605b0f9 Compare May 11, 2026 17:02

AkramBitar requested review from AkramBitar and adecaro May 11, 2026 20:41

AkramBitar force-pushed the bench-fcs-zkp branch from 605b0f9 to 5f40d90 Compare May 12, 2026 08:33

Adding ZKP Benchmarking to test overhead of FSC nodes on TPS

a74dc3a

Signed-off-by: Effi-S <effi.szt@gmail.com>

AkramBitar force-pushed the bench-fcs-zkp branch from 1a354f4 to a74dc3a Compare May 12, 2026 10:31

		@@ -0,0 +1,36 @@
		# Setting up 2 nodes Benchmarking on 2 Severs

		To setup AWS EC2 nodes See: [AWS Setup 2 Machines](../../../token/core/zkatdlog/nogh/v1/validator/bench/transfer_service/aws_setup_2_machines.md)

Conversation

Effi-S commented Feb 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Setting up 2 nodes Benchmarking on 2 Severs (General)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AkramBitar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adecaro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AkramBitar commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AkramBitar left a comment •

edited

Loading