Skip to content

docs: fix invalid JSON in credential offer request examples#1817

Open
TheSeydiCharyyev wants to merge 1 commit into
hyperledger-identus:mainfrom
TheSeydiCharyyev:docs/fix-credential-offer-json-examples
Open

docs: fix invalid JSON in credential offer request examples#1817
TheSeydiCharyyev wants to merge 1 commit into
hyperledger-identus:mainfrom
TheSeydiCharyyev:docs/fix-credential-offer-json-examples

Conversation

@TheSeydiCharyyev

Copy link
Copy Markdown
Contributor

Description

The credential offer request examples in the DIDComm issuance tutorial contain invalid JSON that does not parse:

  • missing comma after "credentialFormat": "JWT" in the JWT example
  • broken "id: key (missing the closing quote, should be "id":) inside credentialSchema, in both the JWT and SD-JWT "Current API" examples

These are syntax-only fixes so the examples are valid JSON and can be copied and run as-is. The field structure already matches the CreateIssueCredentialRecordRequest schema; only the literal text was wrong.

Checklist

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas (N/A — documentation-only change)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works (N/A — documentation-only change)
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Seydi Charyyev <seydi.charyev@gmail.com>
@TheSeydiCharyyev TheSeydiCharyyev requested a review from a team as a code owner June 18, 2026 11:49
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant