docs: fix invalid JSON in credential offer request examples#1817
Open
TheSeydiCharyyev wants to merge 1 commit into
Open
docs: fix invalid JSON in credential offer request examples#1817TheSeydiCharyyev wants to merge 1 commit into
TheSeydiCharyyev wants to merge 1 commit into
Conversation
Signed-off-by: Seydi Charyyev <seydi.charyev@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The credential offer request examples in the DIDComm issuance tutorial contain invalid JSON that does not parse:
"credentialFormat": "JWT"in the JWT example"id:key (missing the closing quote, should be"id":) insidecredentialSchema, in both the JWT and SD-JWT "Current API" examplesThese are syntax-only fixes so the examples are valid JSON and can be copied and run as-is. The field structure already matches the
CreateIssueCredentialRecordRequestschema; only the literal text was wrong.Checklist