fix: filter stream initiator in recv_go_away (#885)#886
Merged
seanmonstar merged 1 commit intohyperium:masterfrom Mar 31, 2026
Merged
fix: filter stream initiator in recv_go_away (#885)#886seanmonstar merged 1 commit intohyperium:masterfrom
seanmonstar merged 1 commit intohyperium:masterfrom
Conversation
recv_go_away closes all streams with id > last_stream_id, regardless of which endpoint initiated them. When a client sends GOAWAY(0) to a server, client-initiated streams (e.g. stream 1) are incorrectly closed, killing in-progress response bodies before any DATA frames are sent. Add peer.is_local_init(stream.id) check so only locally-initiated streams above last_stream_id are closed, per RFC 9113 Section 6.8. Added test client_goaway_does_not_kill_remote_initiated_streams that verifies the server completes a streaming response body on stream 1 after receiving client GOAWAY(NO_ERROR, last_stream_id=0). The test fails without the fix and passes with it.
seanmonstar
approved these changes
Mar 31, 2026
Member
seanmonstar
left a comment
seanmonstar
left a comment
There was a problem hiding this comment.
Nice job investigating, thanks so much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recv_go_away closes all streams with id > last_stream_id, regardless of which endpoint initiated them. When a client sends GOAWAY(0) to a server, client-initiated streams (e.g. stream 1) are incorrectly closed, killing in-progress response bodies before any DATA frames are sent.
Add peer.is_local_init(stream.id) check so only locally-initiated streams above last_stream_id are closed, per RFC 9113 Section 6.8.
Added test client_goaway_does_not_kill_remote_initiated_streams that verifies the server completes a streaming response body on stream 1 after receiving client GOAWAY(NO_ERROR, last_stream_id=0). The test fails without the fix and passes with it.