T2: Register hyp policy set/show/unset/list command group#322
Merged
philcunliffe merged 1 commit intoJul 17, 2026
Conversation
…rnals
Adds the hyp policy command group (LLP 0110/0111) as the class-neutral
successor to the ignore --sync/--local-only/--private aliases: thin
runners in src/core/commands/policy.js parse CLI args and delegate to
the shared runMarkMachineLocal/runUnmarkMachineLocal/runIgnoreCheck
internals in clients.js, now exported and parameterized by a
`component` attribute so telemetry still names the dispatching verb.
runUnmarkMachineLocal gains a class-neutral mode (targetClass
undefined) backing `policy unset <path>` with no trailing token,
removing every machine-local entry governing a path regardless of
class, alongside the existing class-scoped removal used by both
`unignore` and `policy unset <path> <class>`.
`policy list` enumerates the machine-local store directly with a
--json {entries, path} shape; `policy show` reuses runIgnoreCheck so
its --json output stays byte-compatible with `ignore --check --json`.
New test/core/policy-command.test.js mirrors the existing
ignore-private-sync-command coverage for the new spellings, plus list
enumeration and class-neutral unset across multiple governing
entries.
Task-Id: T2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements task T2 of the hyp-policy-verb change set (LLP 0110/0111/0112).
hyp policycommand group viamakeGroupCommandpluspolicy set/show/unset/listentries insrc/core/cli/core_commands.js.src/core/commands/policy.jsthat parse argv(required path for
set, optional forshow, required path + optionaltrailing class for
unset) and delegate to the T1 internals.runMarkMachineLocal/runUnmarkMachineLocal/runIgnoreCheckinsrc/core/commands/clients.js: exported, and themark/unmark internals now take a
componentattribute so telemetrystill names the dispatching verb (
cmd-ignore/cmd-unignorevscmd-policy-set/cmd-policy-unset).policy unset <path>with no trailing token is class-neutral: removesevery machine-local entry governing the path regardless of class.
policy unset <path> <class>stays class-scoped, shared with theexisting
unignorealiases.sync/local-only/ignore->full/local-only/ignore)with unknown-token usage errors (exit 2) naming all three valid tokens.
policy listenumerates the machine-local store with--json {entries, path}.policy show --jsonstays byte-compatible withignore --check --json.test/core/policy-command.test.js(24 tests) mirroringtest/core/ignore-private-sync-command.test.jsfor the new spellings,plus list enumeration and class-neutral unset coverage.
Test plan
npm install(runsprepare->build:types, 0 errors)npm run typechecknpm test(2284 passed, 1 pre-existing skip, 0 failed)Task-Id: T2