fix(reset-credits): critical consume hardening by ellentane · Pull Request #2 · huzky-v/codex-lb

ellentane · 2026-06-19T00:55:47Z

follow-up for Soju06#1053 — ports critical fixes from overlapping Soju06#1056 / Soju06#1014 testing.

backend

live fetch at consume — fetches \GET /wham/rate-limit-reset-credits\ at click time instead of relying on cached snapshot only
force_refresh usage after successful redeem so quota bars + account status update immediately
block paused / reauth / deactivated on consume endpoint (409) before hitting upstream
proxy-aware upstream — credits fetch/consume use codex transport when account has upstream route
ensure_fresh token before upstream calls
audit \�ccount_rate_limit_reset_credit_consumed\ with before count

frontend

disable reset button on paused / reauth / deactivated across accounts page + dashboard list + cards

tests

\uv run pytest tests/unit/test_rate_limit_reset_credits_api.py tests/unit/test_rate_limit_reset_credits_client.py\ — 36 passed
frontend account-actions + account-list tests — 19 passed

happy to fold into Soju06#1053 or adjust anything.

huzky-v · 2026-06-19T06:39:43Z

Thanks for the PR, but I would prefer a zero-db migration ATM as I have a Soju06#1015 implementation which includes a db-stored info
but lately found that it is troublesome to handle multi source of truth.
And keep the complexity low ATM

I think it will be good to insert history record to db after the redeem and handle it on ui (just like the audit log)

ellentane · 2026-06-19T06:48:33Z

Thanks for the PR, but I would prefer a zero-db migration ATM as I have a Soju06#1015 implementation which includes a db-stored info
but lately found that it is troublesome to handle multi source of truth.
And keep the complexity low ATM

I think it will be good to insert history record to db after the redeem and handle it on ui (just like the audit log)

you're right. one question I have is if you've figured out how banking resets works? I've tried reversing the codex app but had no luck.

m4nug · 2026-06-19T07:18:15Z

Thanks for the PR, but I would prefer a zero-db migration ATM as I have a Soju06#1015 implementation which includes a db-stored info
but lately found that it is troublesome to handle multi source of truth.
And keep the complexity low ATM
I think it will be good to insert history record to db after the redeem and handle it on ui (just like the audit log)

you're right. one question I have is if you've figured out how banking resets works? I've tried reversing the codex app but had no luck.

Checkout: https://github.com/aaamosh/codex-reset

huzky-v · 2026-06-19T07:21:37Z

Thanks for the PR, but I would prefer a zero-db migration ATM as I have a Soju06#1015 implementation which includes a db-stored info
but lately found that it is troublesome to handle multi source of truth.
And keep the complexity low ATM
I think it will be good to insert history record to db after the redeem and handle it on ui (just like the audit log)

you're right. one question I have is if you've figured out how banking resets works? I've tried reversing the codex app but had no luck.

Checkout: https://github.com/aaamosh/codex-reset

I am using this repo as the logic base.
And I think he is referring to the Codex App handling on displaying/logic on banking resets?

m4nug · 2026-06-19T07:28:38Z

d I think he is referring to the Codex App handling on displaying/logic on banking reset

I have not looked into it deeply myself yet, but I can help with this if you would like.

From quickly checking it out it looks like you just use these two:

GET /wham/rate-limit-reset-credits List your banked credits and current statuses
POST /wham/rate-limit-reset-credits/consume Redeem one credit (body: credit_id, redeem_request_id)

using the existing auth header.

ellentane · 2026-06-19T13:57:59Z

d I think he is referring to the Codex App handling on displaying/logic on banking reset

I have not looked into it deeply myself yet, but I can help with this if you would like.

From quickly checking it out it looks like you just use these two:

GET /wham/rate-limit-reset-credits List your banked credits and current statuses POST /wham/rate-limit-reset-credits/consume Redeem one credit (body: credit_id, redeem_request_id)

using the existing auth header.

Can you verify that these endpoints actually show resets? I have a feeling a person must first go to the codex app, receive the reset and only then does the endpoint actually report the reset.

I could absolutely be wrong here though, feel free to correct me and test this yourself.

huzky-v · 2026-06-19T14:06:37Z

d I think he is referring to the Codex App handling on displaying/logic on banking reset

I have not looked into it deeply myself yet, but I can help with this if you would like.

From quickly checking it out it looks like you just use these two:

GET /wham/rate-limit-reset-credits List your banked credits and current statuses POST /wham/rate-limit-reset-credits/consume Redeem one credit (body: credit_id, redeem_request_id)

using the existing auth header.

Can you verify that these endpoints actually show resets? I have a feeling a person must first go to the codex app, receive the reset and only then does the endpoint actually report the reset.

I could absolutely be wrong here though, feel free to correct me and test this yourself.

In my build, one of the account does not login to Codex desktop, but still correctly show I have 2 resets remaining

Does not test the actual reset tho

huzky-v · 2026-06-19T17:43:47Z

added api functionality to fetch and redeem the pooled account's reset credit
You may need to adjust PR accordingly.

ellentane · 2026-06-20T14:44:16Z

added api functionality to fetch and redeem the pooled account's reset credit
You may need to adjust PR accordingly.

currently out swimming will do later today

…adaptation

…alog

ellentane · 2026-06-21T14:31:40Z

if you need any other changes then please tell me.

huzky-v · 2026-06-21T16:33:05Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: db33f9f602

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ellentane · 2026-06-21T16:48:11Z

addressed the codex review

huzky-v · 2026-06-21T16:48:35Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 83affefcf1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…rent cache invalidation and redeem UX behavior.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7d396d99d0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

huzky-v · 2026-06-22T03:46:42Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45bee550c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…credits Reset-credit polling must not mutate account status (spec rate-limit-reset-credits: polling failures including 401 log and retain the prior snapshot; usage refresh owns token refresh and deactivation). The forced auth_manager.ensure_fresh(force=True) retry on a 401 flowed into AuthManager.refresh_account, which persists REAUTH_REQUIRED / DEACTIVATED on permanent refresh failure. Remove the auth_manager retry loop from _refresh_account_reset_credits so a 401 logs and keeps the cache in a single attempt. This also covers the dashboard GET cache-miss path that reuses the helper. Add REAUTH_REQUIRED to the account-summary ineligible set so a reauth-required account with a stale cached snapshot no longer surfaces available_reset_credits in list/header/dashboard badges, matching the scheduler skip set and the GET/consume eligibility checks.

huzky-v · 2026-06-22T08:04:55Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 837ea46bac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-22T08:10:13Z

+        credits_response = await effective_fetch_fn(
+            access_token,
+            redeem_account.chatgpt_account_id,
+            route=route,
+            allow_direct_egress=route is None,


Preserve the cached snapshot gate before redeeming

The OpenSpec for this change still says POST /consume must return a 409 without calling upstream when this replica has no cached snapshot or the cached available_count <= 0, but this path fetches live credits before consulting the store and then selects from that response. In a cold replica or after local cache invalidation, a write-capable caller can redeem an irreversible reset credit even though the account summary exposes 0/hides the affordance, and it bypasses the cached-count guard intended to serialize local state.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-06-22T08:10:13Z

+        return None
+
+    async def refresh_usage(account: Account) -> None:
+        await usage_updater.force_refresh(account)


Treat false force-refresh results as failures

UsageUpdater.force_refresh() catches refresh exceptions and returns False, so this callback currently falls through as if the post-consume usage refresh succeeded. When /wham/usage is disabled or transiently fails after a credit was consumed, the snapshot has already been invalidated and the restore path is never run, leaving remaining reset credits hidden until a later reset-credit poll and the account status stale until a successful usage refresh; branch on the boolean or raise to trigger the existing restore logic.

Useful? React with 👍 / 👎.

huzky-v · 2026-06-22T08:39:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b659b9ed84

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

huzky-v · 2026-06-22T09:00:50Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5b1c6f902

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-22T09:06:08Z

+    if credit is None:
+        raise DashboardConflictError("No available reset credit", code="no_available_reset_credit")


Invalidate stale cache when live fetch finds no credit

When the account summary still has a cached positive count but the new live fetch at consume time returns available_count: 0 (for example the credit expired or was redeemed outside this process), this branch returns 409 without updating or invalidating the stored snapshot. Because the frontend does not invalidate queries on consume failure, the same stale reset button/details can remain visible until a later scheduler tick; clear or replace the snapshot from credits_response before returning the conflict.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-06-22T09:06:08Z

+        if account.status in _RESET_CREDITS_SKIP_STATUSES:
+            continue


Clear skipped account snapshots before they can be reused

For accounts that are paused, require reauth, or are deactivated while a reset-credit snapshot is cached, this continue now leaves the old snapshot in memory. If the account is later resumed before the next successful poll, account summaries start reading that old store.get(account.id) again and can advertise a credit that expired or was spent while the account was ineligible; the previous implementation invalidated skipped accounts, so either keep that invalidation or force a fresh fetch before reused snapshots become visible.

Useful? React with 👍 / 👎.

huzky-v · 2026-06-22T09:12:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f380c5f296

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

huzky-v · 2026-06-22T09:23:49Z

@codex review

chatgpt-codex-connector · 2026-06-22T09:31:41Z

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 90ff8618b0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

huzky-v · 2026-06-22T09:35:11Z

Thanks for the contribution

fix(reset-credits): critical consume hardening and zero-db migration …

49f35e7

…adaptation

ellentane force-pushed the feat/banked-reset-critical-fixes branch from e23d2cf to 49f35e7 Compare June 21, 2026 13:50

ellentane added 2 commits June 21, 2026 15:58

fix(test): mock timers to prevent input-otp leaks in auth-gate

93ab24b

fix(web): add space between datetime and countdown in reset credit di…

dabf430

…alog

chore(web): remove auto-generated package-lock.json

db33f9f

chatgpt-codex-connector Bot reviewed Jun 21, 2026

View reviewed changes

Comment thread app/modules/rate_limit_reset_credits/api.py Outdated

Comment thread app/modules/rate_limit_reset_credits/api.py Outdated

Comment thread app/modules/rate_limit_reset_credits/api.py Outdated

fix(api): address codex review findings for rate limit reset credits

83affef

chatgpt-codex-connector Bot reviewed Jun 21, 2026

View reviewed changes

Comment thread app/modules/rate_limit_reset_credits/api.py Outdated

Comment thread frontend/src/features/accounts/components/reset-credit-confirm-dialog.tsx

Align reset-credit eligibility and confirmation-dialog specs with cur…

7d396d9

…rent cache invalidation and redeem UX behavior.

chatgpt-codex-connector Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread app/core/clients/rate_limit_reset_credits.py Outdated

Comment thread app/modules/rate_limit_reset_credits/api.py

Disable default retries for reset credit redemption

45bee55

chatgpt-codex-connector Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread app/core/usage/reset_credits_refresh_scheduler.py Outdated

Comment thread app/core/usage/reset_credits_refresh_scheduler.py

chatgpt-codex-connector Bot reviewed Jun 22, 2026

View reviewed changes

Treat false force-refresh results as failures

b659b9e

chatgpt-codex-connector Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread app/modules/rate_limit_reset_credits/api.py Outdated

Comment thread app/modules/rate_limit_reset_credits/api.py

Fix reset-credit consume audit and refresh cache invalidation

c5b1c6f

chatgpt-codex-connector Bot reviewed Jun 22, 2026

View reviewed changes

Clear skipped account snapshots before they can be reused

f380c5f

chatgpt-codex-connector Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread app/modules/rate_limit_reset_credits/api.py

Invalidate stale reset-credit cache on empty fresh fetch

90ff861

huzky-v merged commit acfa251 into huzky-v:feat/banked-reset Jun 22, 2026

		if credit is None:
		raise DashboardConflictError("No available reset credit", code="no_available_reset_credit")

Conversation

ellentane commented Jun 19, 2026

backend

frontend

tests

Uh oh!

huzky-v commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ellentane commented Jun 19, 2026

Uh oh!

m4nug commented Jun 19, 2026

Uh oh!

huzky-v commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m4nug commented Jun 19, 2026

Uh oh!

ellentane commented Jun 19, 2026

Uh oh!

huzky-v commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huzky-v commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ellentane commented Jun 20, 2026

Uh oh!

ellentane commented Jun 21, 2026

Uh oh!

huzky-v commented Jun 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ellentane commented Jun 21, 2026

Uh oh!

huzky-v commented Jun 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

huzky-v commented Jun 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

huzky-v commented Jun 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

huzky-v commented Jun 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

huzky-v commented Jun 19, 2026 •

edited

Loading

huzky-v commented Jun 19, 2026 •

edited

Loading

huzky-v commented Jun 19, 2026 •

edited

Loading

huzky-v commented Jun 19, 2026 •

edited

Loading