Skip to content

chore: remove the internal MCP mount policy draft from the public tree - #47

Merged
hummbl-dev merged 1 commit into
mainfrom
chore/remove-internal-mcp-mount-manifest
Oct 21, 2026
Merged

hummbl-dev merged 1 commit into
mainfrom
chore/remove-internal-mcp-mount-manifest

Conversation

@hummbl-dev

@hummbl-dev hummbl-dev commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

What this removes

mcp-mount-manifest.draft.yaml from the repository root.

Why

It is internal fleet topology, and this repository is public. The file enumerates the fleet's internal MCP server names, tailnet and RFC1918 SSRF-deny patterns, and notes on which mounts carry a bridge token or a PAT-bearing process. None of that belongs in a public tree that also has a live Zenodo DOI and a PyPI release. The mount policy is maintained in the fleet's internal registry.

It is stale. Its own header declares it a DRAFT, cites an idea pack under docs/research/idea-packs/2026-09-23-sidekick-mcp-mount-manifest.md that does not exist in this repository, and states it is "uncommitted" while in fact being tracked.

Nothing reads it. The only references to the filename in the repository are inside the file itself ΓÇö no code, no workflow, no test, no config loads it. Removal changes no runtime behaviour.

Zenodo re-check (requested alongside this removal)

Queried https://zenodo.org/api/records/23001340 on 2026-10-20. The deposit contains exactly three files:

File Bytes
nakedagent_paper.pdf 273,879
nakedagent_paper.tex 23,527
references.bib 3,138

The mount manifest is not in the Zenodo deposit, so no version bump or retraction is needed for it there. I also grepped the deposited LaTeX source for internal identifiers (tailnet hostnames, bridge URLs and tokens, internal MCP server names) ΓÇö no matches. The Zenodo exposure is limited to the paper artifacts, which contain no fleet topology.

Risk

None to runtime. One file deleted, no code path touched, no dependency or packaging change.

Review route

Per cross-check-protocol.md:

  • Requested reviewer: codex (non-author, scope-fit, different runtime and model family).
  • Fallback reviewer: devin.
  • Fallback trigger: no response within one active turn or 4 hours, whichever is earlier.
  • The author (opencode) is not an eligible reviewer for this artifact.

Related

This is the public-surface half of a broader review of this repository and hummbl-io/oss; the rest of the findings are tracked as issues, and the internal-side remediation (the mount policy's canonical home) is fleet-internal.


Note

Low Risk
Single unused draft YAML deleted; no runtime, packaging, or dependency paths touched.

Overview
Deletes mcp-mount-manifest.draft.yaml from the repository root ΓÇö a draft, unimplemented policy that classified MCP servers into mount tiers (t0/t1/t2) with tool patterns, SSRF URL denies, and fleet-specific server notes.

The file is removed because it exposed internal fleet topology and security posture (server names, credential-bearing mounts, tailnet/RFC1918 deny lists) in a public repo, was stale (draft header, missing idea-pack reference), and had no consumers ΓÇö no code, tests, or config referenced it, so behaviour is unchanged.

Reviewed by Cursor Bugbot for commit 65a09fc. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Documentation
    • Removed the draft MCP mount manifest and its documented mount policies, including fail-closed defaults, namespace and collision handling, mount-event recording, and tiered server access rules.
    • Removed documentation covering tool and path restrictions, aliases, server collision handling, and distinctions between Claude-managed connectors and explicitly denied servers.

CI status on this PR

Gitleaks Secret Scan fails here, and not because of this change. The scan runs
gitleaks git, which scans all refs (git log -p -U0 --full-history --all), and it
trips the generic-api-key rule on a prose line in an unrelated branch:

RuleID: generic-api-key File: docs/risk-contract/PILOT-RESULTS.md:10 Commit: a46409d3 Branch: origin/rescue/2026-10-17/feat/codex/runtime-risk-contract

It is a false positive on ordinary prose, and the file does not exist on main. The effect is
that every PR in this repository is red — the last green CI run on main was 2026-10-13,
before that branch existed. Tracked separately in issue #48, with the reproduction and the
suggested fix (scope the scan to the candidate's history rather than widening an allowlist).

The test matrix on this PR is green (test (windows-latest, 3.12), test (ubuntu-latest, 3.10),
test (ubuntu-latest, 3.14) — all success).

The file is an internal fleet mount policy: it enumerates the fleet's internal MCP servers, tailnet and RFC1918 SSRF-deny patterns, and notes on which mounts carry a bridge token or a PAT-bearing process. That is fleet topology, not project documentation, and this repository is public with a live Zenodo DOI.

It is also stale: its header cites an idea pack under docs/research/idea-packs/ that does not exist, it declares itself a DRAFT, and no code reads it - the only references to the filename are inside the file itself.

The mount policy is maintained in the fleet's internal registry. Removing the file changes no runtime behaviour.
@cursor

cursor Bot commented Oct 20, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: e32d2809-9e6a-4352-879e-5794b5c4b34d)

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ae80ca4a-66da-4899-83cc-95b0ca426a8a
📥 Commits

Reviewing files that changed from the base of the PR and between 9b8c300 and 65a09fc.

📒 Files selected for processing: 1
  • mcp-mount-manifest.draft.yaml
💤 Files with no reviewable changes: 1
  • mcp-mount-manifest.draft.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The draft MCP mount manifest was deleted. Its fail-closed defaults, server classifications, mount restrictions, collision rules, mount-event recording, and connector reachability note were removed.

Changes: MCP mount manifest removal

Layer / File(s) Summary
Remove draft MCP mount policy
mcp-mount-manifest.draft.yaml
The draft manifest and its schema metadata, defaults, server classifications, restrictions, collision rules, event recording, and connector reachability note were removed.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 65a09

This change removes an unused draft file that described internal fleet topology. It has no expected runtime effect and is low risk to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing the internal MCP mount policy draft from the public repository tree.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hummbl-dev

Copy link
Copy Markdown
Member Author

Peer review (devin): Scope +0/-111 across 1 file (deletes mcp-mount-manifest.draft.yaml). Findings: none found — correct fix; the draft published internal fleet MCP topology and credential-handling notes publicly (flagged as B-6/P1 in hummbl-governance#509). Note: Gitleaks Secret Scan fails, but the single finding is a pre-existing generic-api-key hit in docs/risk-contract/PILOT-RESULTS.md:L10 from an earlier commit — unrelated to this deletion; needs a separate allowlist/triage task. Tests pass on all matrix legs. Verdict: LOOKS_GOOD — merge; fix the gitleaks gate separately.

@hummbl-dev
hummbl-dev merged commit d3fa4a7 into main Oct 21, 2026
10 of 12 checks passed
@hummbl-dev
hummbl-dev deleted the chore/remove-internal-mcp-mount-manifest branch October 28, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant