Skip to content

[CI] Add click as an explicit dependency (typer 0.26.0 fix)#4270

Merged
hanouticelina merged 1 commit into
mainfrom
fix-click-explicit-dep
May 26, 2026
Merged

[CI] Add click as an explicit dependency (typer 0.26.0 fix)#4270
hanouticelina merged 1 commit into
mainfrom
fix-click-explicit-dep

Conversation

@hanouticelina
Copy link
Copy Markdown
Collaborator

@hanouticelina hanouticelina commented May 26, 2026

Summary

  • Typer 0.26.0 (released 2026-05-26) removed click from its required dependencies and now ships a vendored copy of Click internally — see typer#1774.
  • We import the public click package directly in cli/_cli_utils.py, cli/_help_formatter.py, and cli/skills.py, so we need to declare it explicitly now that typer no longer brings it along.
  • This unblocks the check-imports CI job, which started failing on every PR today because from huggingface_hub import * triggers cli/_cli_utils.py (via the lazy loader) and that module's import click blew up.

Note

Low Risk
Packaging-only change that restores a previously transitive dependency; no runtime logic changes.

Overview
Adds click>=8.4.0 to install_requires in setup.py so the public click package is installed directly.

Typer 0.26.0 no longer pulls in click as a dependency, but the hub CLI still imports click in modules such as _cli_utils.py, _help_formatter.py, and skills.py. Without this pin, installs and CI checks that load those modules (for example check-imports via from huggingface_hub import *) can fail when click is missing.

Reviewed by Cursor Bugbot for commit 680e2f1. Configure here.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinact found unpinned actions in this repo.

Auto-fixable, but outside this PR's diff (run pinact run locally and commit):

  • .github/workflows/model_card_consistency_reminder.yml:15actions/checkout@v6actions/checkout@de0fac2e45… # v6.0.2
  • .github/workflows/python-prerelease.yml:34actions/checkout@v6actions/checkout@de0fac2e45… # v6.0.2
  • .github/workflows/python-quality.yml:23- actions/checkout@v6- actions/checkout@de0fac2e45… # v6.0.2
  • .github/workflows/python-quality.yml:25actions/setup-python@v6actions/setup-python@a309ff8b42… # v6.2.0
  • .github/workflows/python-tests.yml:22actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6actions/setup-python@a309ff8b42… # v6.2.0
  • .github/workflows/python-tests.yml:57actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6actions/setup-python@a309ff8b42… # v6.2.0
  • .github/workflows/python-tests.yml:174actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6actions/setup-python@a309ff8b42… # v6.2.0
  • .github/workflows/release.yml:293- actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6- actions/setup-python@a309ff8b42… # v6.2.0
  • .github/workflows/release.yml:348- actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6- actions/setup-python@a309ff8b42… # v6.2.0
  • .github/workflows/release.yml:435- actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6- actions/setup-python@a309ff8b42… # v6.2.0
  • .github/workflows/release.yml:555- actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6- actions/setup-python@a309ff8b42… # v6.2.0
  • .github/workflows/release.yml:690- actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6- actions/setup-python@a309ff8b42… # v6.2.0
  • .github/workflows/release.yml:1018actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6actions/setup-python@a309ff8b42… # v6.2.0
  • .github/workflows/style-bot-action.yml:184actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6actions/setup-python@a309ff8b42… # v6.2.0
  • .github/workflows/sync-hf-cli-skill.yml:17actions/checkout@v6actions/checkout@de0fac2e45… # v6.0.2
  • .github/workflows/sync-hf-cli-skill.yml:20actions/setup-python@v6actions/setup-python@a309ff8b42… # v6.2.0
  • .github/workflows/sync-hf-cli-skill.yml:46actions/create-github-app-token@v3actions/create-github-app-token@bcd2ba4921… # v3.2.0
  • .github/workflows/sync-hf-cli-skill.yml:53actions/checkout@v6actions/checkout@de0fac2e45… # v6.0.2
  • .github/workflows/sync-hf-cli-skill.yml:60astral-sh/setup-uv@v7astral-sh/setup-uv@37802adc94… # v7.6.0
  • .github/workflows/sync-hf-cli-skill.yml:86peter-evans/create-pull-request@v8peter-evans/create-pull-request@5f6978faf0… # v8.1.1
  • .github/workflows/build_repocard_examples.yaml:18actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6actions/setup-python@a309ff8b42… # v6.2.0
  • .github/workflows/update-inference-types.yaml:22actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6actions/setup-python@a309ff8b42… # v6.2.0
  • .github/workflows/update-inference-types.yaml:37- actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6- actions/setup-node@48b55a011b… # v6.4.0
  • .github/workflows/update-inference-types.yaml:71peter-evans/create-pull-request@5f6978faf089d4d20b00c7766989d076bb2fc7f1 # v8peter-evans/create-pull-request@5f6978faf0… # v8.1.1

@hanouticelina hanouticelina requested a review from Wauplin May 26, 2026 16:28
Copy link
Copy Markdown
Collaborator

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Perfect quick fix yes (while we figure out the vendored part)

@hanouticelina hanouticelina merged commit 1397383 into main May 26, 2026
16 of 26 checks passed
@hanouticelina hanouticelina deleted the fix-click-explicit-dep branch May 26, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants