[CI] Add click as an explicit dependency (typer 0.26.0 fix)#4270
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pinact found unpinned actions in this repo.
Auto-fixable, but outside this PR's diff (run pinact run locally and commit):
.github/workflows/model_card_consistency_reminder.yml:15—actions/checkout@v6→actions/checkout@de0fac2e45… # v6.0.2.github/workflows/python-prerelease.yml:34—actions/checkout@v6→actions/checkout@de0fac2e45… # v6.0.2.github/workflows/python-quality.yml:23—- actions/checkout@v6→- actions/checkout@de0fac2e45… # v6.0.2.github/workflows/python-quality.yml:25—actions/setup-python@v6→actions/setup-python@a309ff8b42… # v6.2.0.github/workflows/python-tests.yml:22—actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6→actions/setup-python@a309ff8b42… # v6.2.0.github/workflows/python-tests.yml:57—actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6→actions/setup-python@a309ff8b42… # v6.2.0.github/workflows/python-tests.yml:174—actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6→actions/setup-python@a309ff8b42… # v6.2.0.github/workflows/release.yml:293—- actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6→- actions/setup-python@a309ff8b42… # v6.2.0.github/workflows/release.yml:348—- actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6→- actions/setup-python@a309ff8b42… # v6.2.0.github/workflows/release.yml:435—- actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6→- actions/setup-python@a309ff8b42… # v6.2.0.github/workflows/release.yml:555—- actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6→- actions/setup-python@a309ff8b42… # v6.2.0.github/workflows/release.yml:690—- actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6→- actions/setup-python@a309ff8b42… # v6.2.0.github/workflows/release.yml:1018—actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6→actions/setup-python@a309ff8b42… # v6.2.0.github/workflows/style-bot-action.yml:184—actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6→actions/setup-python@a309ff8b42… # v6.2.0.github/workflows/sync-hf-cli-skill.yml:17—actions/checkout@v6→actions/checkout@de0fac2e45… # v6.0.2.github/workflows/sync-hf-cli-skill.yml:20—actions/setup-python@v6→actions/setup-python@a309ff8b42… # v6.2.0.github/workflows/sync-hf-cli-skill.yml:46—actions/create-github-app-token@v3→actions/create-github-app-token@bcd2ba4921… # v3.2.0.github/workflows/sync-hf-cli-skill.yml:53—actions/checkout@v6→actions/checkout@de0fac2e45… # v6.0.2.github/workflows/sync-hf-cli-skill.yml:60—astral-sh/setup-uv@v7→astral-sh/setup-uv@37802adc94… # v7.6.0.github/workflows/sync-hf-cli-skill.yml:86—peter-evans/create-pull-request@v8→peter-evans/create-pull-request@5f6978faf0… # v8.1.1.github/workflows/build_repocard_examples.yaml:18—actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6→actions/setup-python@a309ff8b42… # v6.2.0.github/workflows/update-inference-types.yaml:22—actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6→actions/setup-python@a309ff8b42… # v6.2.0.github/workflows/update-inference-types.yaml:37—- actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6→- actions/setup-node@48b55a011b… # v6.4.0.github/workflows/update-inference-types.yaml:71—peter-evans/create-pull-request@5f6978faf089d4d20b00c7766989d076bb2fc7f1 # v8→peter-evans/create-pull-request@5f6978faf0… # v8.1.1
Wauplin
approved these changes
May 26, 2026
Collaborator
Wauplin
left a comment
There was a problem hiding this comment.
Thank you! Perfect quick fix yes (while we figure out the vendored part)
hanouticelina
added a commit
that referenced
this pull request
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clickfrom its required dependencies and now ships a vendored copy of Click internally — see typer#1774.clickpackage directly incli/_cli_utils.py,cli/_help_formatter.py, andcli/skills.py, so we need to declare it explicitly now that typer no longer brings it along.check-importsCI job, which started failing on every PR today becausefrom huggingface_hub import *triggerscli/_cli_utils.py(via the lazy loader) and that module'simport clickblew up.Note
Low Risk
Packaging-only change that restores a previously transitive dependency; no runtime logic changes.
Overview
Adds
click>=8.4.0toinstall_requiresinsetup.pyso the publicclickpackage is installed directly.Typer 0.26.0 no longer pulls in
clickas a dependency, but the hub CLI still importsclickin modules such as_cli_utils.py,_help_formatter.py, andskills.py. Without this pin, installs and CI checks that load those modules (for examplecheck-importsviafrom huggingface_hub import *) can fail whenclickis missing.Reviewed by Cursor Bugbot for commit 680e2f1. Configure here.