fix(web): harden feed reader fallback and rss rendering#944
Merged
gildesmarais merged 4 commits intomainfrom Apr 4, 2026
Merged
fix(web): harden feed reader fallback and rss rendering#944gildesmarais merged 4 commits intomainfrom
gildesmarais merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the web feed rendering path and improves RSS/XSL presentation for better reader compatibility, adding shared UI assets and regression coverage around the responder and XSL output.
Changes:
- Adds/updates RSS XSL rendering (hero, “open in reader” affordance, and item quality indicators) and shared UI primitives.
- Refactors feed responder logging/normalization and tightens responder specs via shared expectations.
- Updates docs and ignore rules, including pnpm-related developer workflow notes.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/public/rss_xsl_spec.rb | New regression coverage for XSL-rendered HTML output (assets, hero, stamping, text cleaning). |
| spec/html2rss/web/feeds/responder_spec.rb | Extracts shared expectations for static source resolution + cache headers. |
| spec/html2rss/web/app_spec.rb | Makes static-feed caching test less cache-collision prone via randomized path. |
| public/shared-ui.css | Expands shared primitives (hero/buttons/tokens) used by both app UI and XSL surfaces. |
| public/rss.xsl | Enhances feed HTML presentation, adds feed-reader link behavior, and improves text cleaning. |
| public/feed-reader-link.js | Adds client-side wiring for “Open in feed reader” fallback behavior. |
| Gemfile | Removes ssrf_filter dependency declaration. |
| docs/README.md | Updates contributor commands (notably make ready) and documents pnpm scripts. |
| docs/architecture.md | Refreshes routing/auth boundary documentation for static vs token feed paths. |
| app/web/feeds/responder.rb | Refactors request resolution + result emission flow for clearer separation. |
| .gitignore | Adds pnpm store and minor cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces several improvements to the feed rendering experience, both visually and functionally, along with some internal refactoring and documentation updates. The most significant changes are a major redesign of the RSS feed XSL template to enhance the UI, the addition of a script to improve feed reader link handling, and a refactor in the feed responder logic. There are also updates to documentation for clarity and accuracy.
Feed UI and UX improvements:
public/rss.xsltemplate to provide a more modern, accessible, and informative feed presentation. This includes a new hero section with icons, improved layout, additional metadata (such as updated/published stamps), and visual signals for item quality (summary, image, tags, byline). The CSS has been extensively updated to support these changes. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Feed reader integration:
public/feed-reader-link.js, which dynamically sets the "Open in feed reader" link to use thefeed:protocol for the current page if not already set, improving compatibility with feed readers. The script is now included in the XSL template. [1] [2] [3]Backend code refactoring:
app/web/feeds/responder.rbby extracting request resolution into a newresolve_requestmethod and improving result emission withemit_response_result, making the code more modular and readable. [1] [2]Documentation and developer experience:
docs/README.mdto clarify make targets, add new OpenAPI verification/linting commands, and switch frontend instructions from npm to pnpm for consistency.docs/architecture.mdto clarify feed routing, authentication, and source resolution logic, with more precise descriptions of static and token-backed feeds.Dependency cleanup:
ssrf_filtergem from theGemfile.