feat(frontend): unify feed/result state flow#943
Merged
gildesmarais merged 5 commits intomainfrom Apr 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates and improves the frontend test suites for the application, focusing on consistency in terminology, better test reliability, and improved clarity in test expectations. The changes include standardizing user-facing text in tests, switching from
windowtoglobalThisfor global objects, and updating test logic to match recent UI and API changes.Most important changes:
Terminology and Text Consistency:
Test Reliability and Modernization:
windowwithglobalThisfor accessing global objects likelocalStorageandhistoryin tests, improving compatibility and reliability in different testing environments. [1] [2] [3] [4] [5]document.getElementByIdtodocument.querySelectorfor improved robustness and flexibility in selecting DOM elements. [1] [2] [3]Test Data and Mocking Improvements:
undefinedinstead ofnullfor uninitialized or missing values, aligning with current code conventions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]UI and UX Flow Adjustments:
Minor Test and Code Cleanups:
hfrompreact) and improved array creation for utility items in tests for better readability. [1] [2]These changes collectively improve test accuracy, maintainability, and ensure that tests reflect the current application behavior and user interface.