-
-
Notifications
You must be signed in to change notification settings - Fork 16
Feat/ux streamline experience #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2797de3
feat: default to browserless in web
gildesmarais c06aa81
feat: streamline first-run onboarding with included feeds
gildesmarais 49074ef
refactor: use html2rss default request strategies
gildesmarais 2a14aae
Remove ssrf_filter dependency
gildesmarais 6772e7f
Strengthen XML error feed spec
gildesmarais 07cc691
Simplify strategy labeling
gildesmarais 91fb8d5
Tighten featured feed examples
gildesmarais d86d9cb
Refine feed result and rendered feed UI
gildesmarais 21eb936
refactor: align web and rss design surfaces
gildesmarais 381c44c
refactor: dedupe shared ui styles
gildesmarais 3ccbe11
fix: align defaults and utility links
gildesmarais 523c546
docs: remove duplicated contributor guidance
gildesmarais 4de4c69
docs: unify and consolidate project documentation
gildesmarais 77a7368
docs: add contract-driven workflow and refine contributor canon
gildesmarais 1e5f54c
refactor: improve utility menu labels and order
gildesmarais e9c6828
docs: add architecture diagram and request lifecycle
gildesmarais File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the
ssrf_filterdependency and the customSsrfFilterStrategymeans this repo no longer enforces a network-level SSRF protection layer for outbound fetches; withconfig/feeds.ymlallowingallowed_urls: ['*']for the admin account, authenticated users can now cause the server to fetch arbitrary URLs using the default Faraday strategy. Please reintroduce an SSRF-safe request strategy (or ensureHtml2rss::RequestServiceis configured to reject private/metadata IP ranges and other sensitive targets) before relying on*allowlists in production configs.