feat(deps): use html2rss in latest development status#728
Merged
gildesmarais merged 7 commits intomasterfrom May 29, 2025
Merged
feat(deps): use html2rss in latest development status#728gildesmarais merged 7 commits intomasterfrom
gildesmarais merged 7 commits intomasterfrom
Conversation
8a01e59 to
718bfa3
Compare
5fa8174 to
88c4e1d
Compare
a693cdc to
312dcbf
Compare
Signed-off-by: Gil Desmarais <[email protected]>
Refactored RSS feed handling in app.rb to eliminate the Html2rssFacade. Merged configuration directly into request handlers, simplifying the feed generation process. This change enhances performance by reducing method calls and improves readability by consolidating logic. Removed unused helper files related to the facade, cleaning up the codebase. Signed-off-by: Gil Desmarais <[email protected]>
…e test Adjusted the expected value of the cache-control header in the response test to include 'no-cache' and 'no-store'. This change ensures that the test accurately reflects the intended caching behavior for responses, improving reliability and correctness.
This commit deletes the RequestPath class and its corresponding tests, as they are no longer needed in the application. This helps reduce code complexity and maintenance overhead.
Replaced the previous RSS construction with a new feed builder to simplify code and improve maintainability. Updated caching logic to align with the new structure, enhancing response handling for auto-source features. Signed-off-by: Gil Desmarais <[email protected]>
Created /app/tmp/rack-cache-body and /app/tmp/rack-cache-meta directories in the Dockerfile to support caching functionality.
312dcbf to
930f823
Compare
Member
Author
|
to test-drive recent changes, accepting the missing binstub for dev-version of html2rss |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #722