feat: provide defaults for dynamic params#254
Merged
gildesmarais merged 1 commit intomasterfrom Sep 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements feature #252 by adding support for default values in dynamic parameters for RSS feed configurations. Instead of requiring explicit parameter values in tests, configs can now define default values that are automatically used when no parameters are provided.
Key changes:
- Added automatic extraction of default parameter values from config files
- Updated test files to remove hardcoded parameter values, relying on defaults instead
- Added parameter validation to ensure all parameters have required fields and default values
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/support/shared_examples/config.yml_spec.rb | Enhanced shared example to extract and use default parameter values, added parameter validation tests |
| spec/html2rss/configs/*.yml_spec.rb | Removed hardcoded parameters from test calls, now using defaults from config files |
| lib/html2rss/configs/*.yml | Added parameters section with type and default value definitions for dynamic configs |
| README.md | Added documentation explaining the new dynamic parameters feature with examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| selector: "section > a" | ||
| extractor: "href" | ||
| descripton: | ||
| description: |
There was a problem hiding this comment.
Fixed typo: 'descripton' has been corrected to 'description'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #252