Skip to content

Bug fixes and a better test suite - #258

Merged
hoytech merged 6 commits into
hoytech:masterfrom
theAnuragMishra:auth-tests
Aug 18, 2026
Merged

Bug fixes and a better test suite#258
hoytech merged 6 commits into
hoytech:masterfrom
theAnuragMishra:auth-tests

Conversation

@theAnuragMishra

@theAnuragMishra theAnuragMishra commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

WIP Ready
This PR

  • fixes a comment in strfry.conf and a bug in shouldSendToSubscriber, makes changes to better control when auth challenges are sent.
  • Refactors tests into common utils and runnable test files for better test organization.
  • adds read related tests for various combinations of authentication status and filters.

… successfully authenticated yet)

also allow count of restricted kinds to authenticated users when restrictReadToInvolvedPubkey is set to false even if the filters are not scoped to the client given client is authenticated
@theAnuragMishra
theAnuragMishra marked this pull request as ready for review August 17, 2026 20:27
@hoytech
hoytech merged commit 5d89a62 into hoytech:master Aug 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants