Skip to content

logind: Set InhibitDelayMaxSec=300 to allow Supervisor graceful shutdown#4577

Merged
sairon merged 1 commit intodevfrom
increase-maximum-shutdown-inhibit-delay
Mar 13, 2026
Merged

logind: Set InhibitDelayMaxSec=300 to allow Supervisor graceful shutdown#4577
sairon merged 1 commit intodevfrom
increase-maximum-shutdown-inhibit-delay

Conversation

@agners
Copy link
Copy Markdown
Member

@agners agners commented Mar 13, 2026

Supervisor takes a logind delay inhibitor lock on startup and releases it after gracefully stopping all add-ons, Home Assistant Core, and plugins in the correct order. The default 5s window is far too short — Core alone can take 40+ seconds to stop. 300s gives enough headroom for a clean shutdown.

Related to: home-assistant/supervisor#6631 #4498

Summary by CodeRabbit

  • Chores
    • Extended the maximum delay for system shutdown from 5 to 300 seconds, allowing applications more time to respond to shutdown requests.

Supervisor takes a logind delay inhibitor lock on startup and releases it
after gracefully stopping all add-ons, Home Assistant Core, and plugins in
the correct order. The default 5s window is far too short — Core alone can
take 40+ seconds to stop. 300s gives enough headroom for a clean shutdown.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@agners agners added this to the 17.2 milestone Mar 13, 2026
@agners agners requested a review from sairon March 13, 2026 14:54
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 46168024-4b61-497e-b5a5-4d8c875bc32a

📥 Commits

Reviewing files that changed from the base of the PR and between 123b023 and a7be551.

📒 Files selected for processing (1)
  • buildroot-external/rootfs-overlay/etc/systemd/logind.conf

📝 Walkthrough

Walkthrough

Updated systemd logind.conf configuration parameter InhibitDelayMaxSec from 5 to 300 seconds in the [Login] section. This controls the maximum delay for inhibitors during system shutdown.

Changes

Cohort / File(s) Summary
Systemd Configuration
buildroot-external/rootfs-overlay/etc/systemd/logind.conf
Updated InhibitDelayMaxSec parameter in [Login] section from 5 to 300, increasing the maximum delay time for inhibitors before shutdown proceeds.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Five became three-hundred, oh what a leap!
More time for the shutdown, a longer sleep,
The logind.conf sings with patient delays,
Let systems rest easy, in their own ways! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating InhibitDelayMaxSec to 300 in logind configuration for graceful Supervisor shutdown.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch increase-maximum-shutdown-inhibit-delay
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting to disable the poems in the walkthrough.

@sairon sairon merged commit 3981c77 into dev Mar 13, 2026
3 checks passed
@sairon sairon deleted the increase-maximum-shutdown-inhibit-delay branch March 13, 2026 16:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2026
@sairon sairon added the os label Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants