Makes alarm_control_panels more flexible on Android auto#6374
Open
poupounetjoyeux wants to merge 7 commits intohome-assistant:mainfrom
Open
Makes alarm_control_panels more flexible on Android auto#6374poupounetjoyeux wants to merge 7 commits intohome-assistant:mainfrom
poupounetjoyeux wants to merge 7 commits intohome-assistant:mainfrom
Conversation
If alarm has code but not required for arming allows arming alarm Keep the logic for disarming regarding the has code Move the logic inside Entity.kt
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
Bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
Member
|
Please sign the CLA to proceed. At a quick glance your check in |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Author
|
Hello @jpelgrom, |
poupounetjoyeux
force-pushed
the
main
branch
2 times, most recently
from
b739402 to
78a971f
Compare
Move methods to an util class to make them simpler to test Fix reversed condition in alarmCanBeArmedWithoutCode()
Author
|
Hello! The change is now ready and tested |
jpelgrom
reviewed
Feb 5, 2026
jpelgrom
reviewed
Feb 5, 2026
jpelgrom
reviewed
Feb 5, 2026
Add some methods for more reliability
jpelgrom
reviewed
Feb 16, 2026
Member
|
I'm going to mark this as draft, please click on 'Ready for review' once you've addressed the comments. |
Add private functions visibility modifiier Check alarm domain everywhere Import assertions in unit tests
Author
Yes sorry didn't have time last week, just done it Thank for your time, I'm new to Kotlin so don't have all subtilities 😅 |
TimoPtr
reviewed
Feb 27, 2026
TimoPtr
reviewed
Feb 27, 2026
TimoPtr
reviewed
Feb 27, 2026
Make constant internal visible for tests only Move the alarm control panel domain to IntegrationDomains Fix log typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If alarm has code but not required for arming allows arming alarm (arm_away)
Impact only Android Auto part of the application
Checklist