DDCNL-12161: TAI - Add in auth caching#425
Open
askar-makkunnath wants to merge 5 commits into
Open
Conversation
SandeepUmredkar
requested changes
Jul 23, 2026
|
|
||
| given (Encrypter with Decrypter) = crypto | ||
|
|
||
| def put[T: Writes](cacheId: CacheId, dataKey: DataKey[T], data: T): Future[(String, String)] = |
Contributor
There was a problem hiding this comment.
I think put should also have recoverWith like get wher ewe log an error and move on, now it would fail bcos of mongo blip
Contributor
Author
There was a problem hiding this comment.
I kept this aligned with Pertax and FANDF, where put() doesn't recover. If we want to make cache writes best-effort, I'd prefer handling it in AuthAction around the putSession call rather than changing the generic repository.
| } | ||
| .recover { | ||
| case x: NoActiveSession => | ||
| logger.error("Failed to authorise: " + x.reason) |
Contributor
There was a problem hiding this comment.
Should we log it as error, because session timeout, in pertax we dont log anything for these error, worth keeping same pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.